Skip to content

Setup Desktop test workflow that detects C++ SDK breakage caused by iOS SDK changes #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 27, 2022
Merged

Setup Desktop test workflow that detects C++ SDK breakage caused by iOS SDK changes #1162

merged 23 commits into from
Dec 27, 2022

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Dec 5, 2022 •
edited
Loading

Description

Add nightly workflow that run firebase desktop tests against iOS tip-of-tree branch.
Also, generate the result report and send to Firestore Nightly Report.

Note: desktop build failed on Windows. Uploaded log files to the original ticket.

Other: Fix "build desktop script does not throw errors". e.g. https://github.com/firebase/firebase-cpp-sdk/actions/runs/3632775054/jobs/6129012424#step:14:1681

Testing

https://github.com/firebase/firebase-cpp-sdk/actions/runs/3635116249
report: #835

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@sunmou99 sunmou99 added the skip-release-notes Skip release notes check label Dec 5, 2022
@sunmou99 sunmou99 changed the title Desktop test against ios tip-of-tree Setup Desktop test workflow that detects C++ SDK breakage caused by iOS SDK changes Dec 6, 2022
@sunmou99 sunmou99 marked this pull request as ready for review December 6, 2022 22:54
@sunmou99 sunmou99 requested a review from jonsimantov December 7, 2022 02:28
@sunmou99 sunmou99 requested a review from ehsannas December 7, 2022 02:30
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Dec 7, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @sunmou99 on commit b07793a
Last updated: Tue Dec 27 17:28 PST 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(2 failed tests)  QueryTest.TestListenUnlistenRelistenSequenceOfMirrorQueries
  ValidationTest.TransactionsRequireValidDocumentReferences
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  TransactionTest.TestGetNonexistentDocumentThenFailPatch
gma [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target]
(2 failed tests)  FirebaseGmaTest.TestRewardedAdLoad
  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
installations [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 8, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 8, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Dec 12, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 12, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2022
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Dec 15, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 15, 2022
@dconeybe
Copy link
Contributor

@sunmou99 Could you re-trigger the test run that surfaced the Windows build error? I've pushed up a commit to this branch that may fix it by setting git's core.eol config setting to lf: e5a4993

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 15, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 15, 2022
@dconeybe
Copy link
Contributor

@sunmou99 Could you re-trigger the test run that surfaced the Windows build error? I've pushed up a commit to this branch that may fix it by setting git's core.eol config setting to lf: e5a4993

@sunmou99 did this core.eol change help anything?

@sunmou99
Copy link
Contributor Author

sunmou99 commented Dec 15, 2022 •
edited
Loading

@sunmou99 Could you re-trigger the test run that surfaced the Windows build error? I've pushed up a commit to this branch that may fix it by setting git's core.eol config setting to lf: e5a4993

@sunmou99 did this core.eol change help anything?

@dconeybe Yes, but the build jobs still failed for a different reason.
https://github.com/firebase/firebase-cpp-sdk/actions/runs/3707050079

LINK : fatal error LNK1104: cannot open file 'pthreads.lib' [D:\a\firebase-cpp-sdk\firebase-cpp-sdk\ta\firestore\iti\CMakeFiles\CMakeScratch\TryCompile-e6r1gy\cmTC_7308e.vcxproj]

@dconeybe
Copy link
Contributor

Hmm. @sunmou99 @ehsannas what do you think about merging this PR with Windows disabled, and then we can work on fixing the windows build in a separate PR? It would be good to have _some_coverage. The marginal gain from adding Windows to the test matrix is quite small.

@ehsannas
Copy link
Contributor

@dconeybe @sunmou99 yeah I think it's still valuable to enable these bots for Linux and macOS.

@dconeybe should we land your commit with the new git config too? or do you want to revert that?

@dconeybe
Copy link
Contributor

@dconeybe @sunmou99 yeah I think it's still valuable to enable these bots for Linux and macOS.

@dconeybe should we land your commit with the new git config too? or do you want to revert that?

My commit should be reverted, since it didn't fix anything.

@sunmou99
Copy link
Contributor Author

@dconeybe @sunmou99 yeah I think it's still valuable to enable these bots for Linux and macOS.
@dconeybe should we land your commit with the new git config too? or do you want to revert that?

My commit should be reverted, since it didn't fix anything.

reverted

@sunmou99 sunmou99 enabled auto-merge (squash) December 27, 2022 22:08
@sunmou99 sunmou99 removed the tests: failed This PR's integration tests failed. label Dec 27, 2022
@sunmou99 sunmou99 merged commit b07793a into main Dec 27, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 27, 2022
@sunmou99 sunmou99 deleted the feature/against-ios-main branch December 27, 2022 23:14
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 28, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 28, 2022
@firebase firebase locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunmou99 @dconeybe @ehsannas