Skip to content

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Oct 18, 2021

Description

Remove calls to LogInfo, LogError, LogDebug during obj-c +load.

Obj-C +load is run before C++ static initializers, so we really shouldn't call into any Firebase C++ SDK functions that aren't meant to be called during +load.


Testing

Making sure previous iOSes don't fail via CI, but can't test in iOS 15 myself yet.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

This could be causing an issue in C++ as global class constructors have not yet been run.
@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed cla: yes labels Oct 18, 2021
@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 18, 2021
@github-actions
Copy link

github-actions bot commented Oct 18, 2021

✅  Integration test succeeded!

Requested by @jonsimantov on commit 6946d8a
Last updated: Mon Nov 22 18:00 PST 2021
View integration test log & download artifacts

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 18, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 18, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 18, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 18, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 18, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Oct 19, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 19, 2021
@jonsimantov jonsimantov requested a review from a-maurice October 25, 2021 20:36
@jonsimantov jonsimantov enabled auto-merge (squash) November 22, 2021 22:01
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Nov 22, 2021
@jonsimantov jonsimantov disabled auto-merge November 22, 2021 23:27
@jonsimantov jonsimantov enabled auto-merge (squash) November 22, 2021 23:28
@jonsimantov jonsimantov merged commit 6946d8a into main Nov 23, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Nov 23, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 23, 2021
DellaBitta added a commit that referenced this pull request Dec 1, 2021
* Fix test on emulator workflow failures (#734)

* If simulator  install ios app failed, reset simulator and try again (#733)

* Trigger workflow move github api cod to github.py (#746)

* Fix a data race that could manifest as null pointer dereference in FutureBase::Release() (#747)

* Cancel callbacks for messaging (#745)

* Cancel callbacks for messaging

util::Terminate is referenced counted som when there ar more APIs than messaging active the callbacks will not be canceled until later and still cause a NULL ref due to the FutureData being destroyed now.

* Cancel callback earlier

* Update readme

* Remove "Android" tag from the release notes entry for #747 (#749)

* Remove calls to LogInfo, LogError, LogDebug during obj-c +load. (#706)

* Remove calls to LogInfo, LogError, LogDebug during obj-c +load.

This could be causing an issue in C++ as global class constructors have not yet been run.

* Add Objective-C/C++ and Java to code formatter script; format those files. (#755)

* Allow format_code to format .m/.mm files; clang-format already knows how.

* Run format_code.py on all objective-c/objective-c++ files.

* Add Java file extensions to format_code.py

* Format all Java source files.

* Remove check for objc header, as they are now supported.

* Format objective-c .h files.

* Don't let lint comment on line length any more; code formatting will report that.

* Messaging crash during initialization (#760)

* Messaging crash during initialization

* Update readme

* Don't redeclare inherited state in CredentialsProviderDesktop (#731)

* Reduce disk space usage when packaging the built SDK (#763)

Remove intermediate build files during desktop packaging step.

This should reduce the disk space usage, as those files (*.o and *.obj) are not required when merging libraries.

* Workaround for Linux x86 build:  downgrade libraries on GitHub runners (#764)

When installing 32-bit Linux dependencies on GitHub runners, downgrade libpcre2-8-0 to an earlier version to ensure compatibility with the i386 version of the package. This is something that should be fixed in a subsequent Ubuntu release and so is a temporary workaround.

This also adds checks to the various prerequisite commands run by build_desktop.py, which was previously just silently ignoring errors (making this much harder to track down). Now it will error out as soon as a command fails.

Co-authored-by: Mou Sun <[email protected]>
Co-authored-by: Denver Coneybeare <[email protected]>
Co-authored-by: Tobias Barendt <[email protected]>
Co-authored-by: Jon Simantov <[email protected]>
Co-authored-by: Sebastian Schmidt <[email protected]>
@jonsimantov jonsimantov deleted the bugfix/ios15_load branch December 2, 2021 05:42
@firebase firebase locked and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants