Skip to content

Conversation

adamvduke
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2020

Coverage Report

Affected SDKs

No changes between base commit (be99c93) and head commit (96267bbf).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (96267bbf) is created by Prow via merging commits: be99c93 2061b2d.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2020

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (be99c93) Head (96267bbf) Diff
    aar 410 kB 409 kB -416 B (-0.1%)
    apk (aggressive) 549 kB 324 kB -226 kB (-41.1%)
    apk (debug) 1.61 MB 1.28 MB -336 kB (-20.8%)
    apk (release) 1.35 MB 1.04 MB -310 kB (-23.0%)
  • firebase-installations

    Type Base (be99c93) Head (96267bbf) Diff
    aar 58.2 kB 58.2 kB +3 B (+0.0%)
  • transport-runtime

    Type Base (be99c93) Head (96267bbf) Diff
    apk (debug) 82.5 kB 82.5 kB -1 B (-0.0%)

Test Logs

Notes

Head commit (96267bbf) is created by Prow via merging commits: be99c93 2061b2d.

@googlebot googlebot added the cla: yes Override cla label Jul 7, 2020
Copy link
Contributor

@mrwillis21 mrwillis21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor requests, but otherwise LGTM.

@adamvduke adamvduke merged commit 04a9e0c into master Jul 8, 2020
@adamvduke adamvduke deleted the adamvduke/crashlytics-use-fis-api branch July 8, 2020 16:09
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants