Update crashlytics global data collection #1434
Conversation
Coverage ReportAffected SDKsNo changes between base commit (f1e32c1) and head commit (462d9124). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (462d9124) is created by Prow via merging commits: f1e32c1 e29abd6. |
|
The public api surface has changed for the subproject firebase-crashlytics: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (462d9124) is created by Prow via merging commits: f1e32c1 e29abd6. |
|
The public api surface has changed for the subproject firebase-crashlytics: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-crashlytics: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
| crashlyticsDataCollectionEnabled = enabled; | ||
| crashlyticsDataCollectionExplicitlySet = true; | ||
| sharedPreferences.edit().putBoolean(FIREBASE_CRASHLYTICS_COLLECTION_ENABLED, enabled).commit(); | ||
| public synchronized void setCrashlyticsDataCollectionEnabled(Boolean enabled) { |
There was a problem hiding this comment.
We can help our future selves by adding some comments here :)
| arbiter.setCrashlyticsDataCollectionEnabled(false); | ||
| assertFalse(arbiter.isAutomaticDataCollectionEnabled()); | ||
|
|
||
| when(mockPrefs.contains(PREFS_KEY)).thenReturn(false); |
There was a problem hiding this comment.
Can you split this up into separate tests that express the conditions they check?
...ics/src/main/java/com/google/firebase/crashlytics/internal/common/DataCollectionArbiter.java
Show resolved
Hide resolved
...ics/src/main/java/com/google/firebase/crashlytics/internal/common/DataCollectionArbiter.java
Outdated
Show resolved
Hide resolved
|
/test device-check-changed |
| @@ -463,4 +463,23 @@ public boolean didCrashOnPreviousExecution() { | |||
| public void setCrashlyticsCollectionEnabled(boolean enabled) { | |||
| core.setCrashlyticsCollectionEnabled(enabled); | |||
| } | |||
|
|
|||
| /** | |||
| * Enables/disables/clears automatic data collection config by Crashlytics. | |||
No description provided.