Skip to content

Add subtitle in ApsAlert #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 27, 2018
Merged

Add subtitle in ApsAlert #219

merged 8 commits into from
Nov 27, 2018

Conversation

chemidy
Copy link
Contributor

@chemidy chemidy commented Nov 23, 2018

Add subtitle field in ApsAlert payload + tests

hiranya911
hiranya911 suggested changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one additional test case required for completeness.

@hiranya911 hiranya911 self-assigned this Nov 26, 2018
hiranya911
hiranya911 approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 merged commit 3bade2b into firebase:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chemidy @hiranya911