Accept prefixed topic names #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avishalom
approved these changes
Feb 7, 2018
bojeil-google
approved these changes
Feb 7, 2018
hiranya911
added a commit
that referenced
this pull request
Feb 13, 2018
* New FCM API * Adding FCM unit tests * Added other FCM message types and tests * Minor cleanup * APNS message validation * Cleaned up tests * Improved error handling * Updated typings and integration tests * Updated typings * Added APNS types in the impl * Updated unit tests * Implemented dry run mode * Updated API; Implemented TTL numeric values; More test coverage * Boosted test coverage to almost 100% * Updated changelog * Changing test data * Adding some documentation; Addressing some code review feedback * Accept prefixed topic names (#203) * Accept prefixed topic names * Further validating topic names * Handling the New FCM Error Codes (#206) * Using new FCM error codes * Adding new SDK error code message-rate-exceeded * Updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new FCM API does not accept topic names prefixed with
/topics/. But we can easily check for this in the SDK and remove it. This results in a better and consistent dev experience since the other methods in this API accepts prefixed topic names.