Skip to content

Conversation

hiranya911
Copy link
Contributor

Continuing the work started by @MathBunny, this PR adds support for auto-generating typings for the Storage APIs:

  • Moved existing admin.storage typings into a new src/storage.d.ts file, so they can be easily screened out during typing auto-generation.
  • Added src/storage/index.ts file with the barrel exports.
  • Updated the gulpfile to auto-generate typings for Storage.

@hiranya911 hiranya911 added the release:stage Stage a release candidate label Sep 3, 2020
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!
LGTM!

@hiranya911 hiranya911 merged commit f11aed7 into master Sep 3, 2020
@hiranya911 hiranya911 deleted the hkj-storage-typegen branch September 3, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants