Google Cloud Storage API [WIP] #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojeil-google
suggested changes
Jul 31, 2017
src/storage/storage.ts
Outdated
| */ | ||
| public delete(): Promise<void> { | ||
| // There are no resources to clean up. | ||
| return Promise.resolve(undefined); |
There was a problem hiding this comment.
Promise.resolve()
Otherwise this would return Promise
src/storage/storage.ts
Outdated
| } else { | ||
| bucketName = this.appInternal.options.storageBucket; | ||
| } | ||
| if (typeof bucketName !== 'string' || bucketName === '') { |
There was a problem hiding this comment.
Suggestion: you can also use validator.sNonEmptyString
test/integration/storage.js
Outdated
|
|
||
| function testDefaultBucket() { | ||
| const bucket = admin.storage().bucket(); | ||
| return verifyBucket(bucket, 'storage().bucker()') |
test/unit/storage/storage.spec.ts
Outdated
| import {FirebaseApp} from '../../../src/firebase-app'; | ||
| import {Storage} from '../../../src/storage/storage'; | ||
|
|
||
| describe('Messaging', () => { |
|
|
||
| describe('bucket(valid)', () => { | ||
| it('should return a bucket object', () => { | ||
| expect(storage.bucket('foo').name).to.equal('foo'); |
There was a problem hiding this comment.
Should you add another valid test when no bucket name is added?
|
Thanks for the feedback. I've made all the suggested changes. |
bojeil-google
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code borrowed from #38
Exposes Google Cloud Storage API via the Java Admin SDK:
Storagetype that wraps the GCS storage clientbucket()method.go/firebase-admin-gcs