-
Notifications
You must be signed in to change notification settings - Fork 1
Partial Errors Implementation #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
reviewed
Mar 24, 2025
ncooke3
reviewed
Mar 24, 2025
ncooke3
reviewed
Mar 24, 2025
ncooke3
reviewed
Mar 24, 2025
AnyDataConnectError just becomes a container of DataConnectError so it can contain both base and domain errors
ncooke3
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly documentation improvements to which I left suggestions to make it easier to address. I also had two impl. questions in GrpcClient.swift
.
Adds support for GQL partial errors.
This change also refactors the base DataConnectError class to be a protocol and specific errors to be structs that implement this protocol.
Refactored Error Types