refactor #1
Merged
refactor #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
duongphuhiep
added a commit
to duongphuhiep/ore
that referenced
this pull request
Nov 1, 2024
* fix S1028: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (gosimple) * fix SA5009: Printf format %c has arg firasdarwish#1 of wrong type *T (staticcheck) * fix SA1029: should not use built-in string type as context key. => Add more string alias for logic and type safety * fix SA9004: only the first constant in this group has an explicit type (staticcheck) * rename "entry" to "serviceResolver" * make serviceResolver return "any" instead of T so that resolving alias would be possible later * enhance codes duplications ("replaceEntry") * make many test structs (for eg. "Counter") private, so that invisible from consumers * fix others warnings in tests codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.