Simplify Air route operator methods #885
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having inherited its Application and Routing classes from FastAPI, Air has a lot of extraneous method arguments for route handlers related to response types. This PR removes those arguments, to simplify the API design.
Unfortunately in doing so we violate the Liskov substitution principle, which causes understandable type failures. This PR addresses that by telling type checkers to ignore that error.
I'm not sure breaking LSP is the right approach. Other options include:
Note: This doesn't yet touching
routing.py, but if we decide to go this path I'll implement it.Pull request type
Please check the type of change your PR introduces:
Pull request tasks
The following have been completed for this task:
examplesfolderChecklist
just testandjust qa, ensuring my code changes passes all existing tests