Add Hi* helpers for hi-intensity colors #68
Conversation
|
Hi @rhysd This looks ok. I think it would be worth adding because it doesn't break anything. However I would like to see a small addition to the packages documentation that goes over this a little bit. Just check the other examples to get a sense. |
color.go
Outdated
| // foreground. | ||
| func HiBlueString(format string, a ...interface{}) string { return colorString(format, FgHiBlue, a...) } | ||
|
|
||
| // HiHiMagentaString is an convenient helper function to return a string with hi-intensity magenta |
There was a problem hiding this comment.
Thank you for catching this (I reviewed patch myself before creating PR, but I overlooked this...). I'll fix this today.
|
I fixed the point with rebasing. |
I tried to revise docs instead of copy-and-paste docs of existing helpers in b4376ec. I'm not sure they are better documents than previous, tho. |
|
@rhysd I meant the examples here: https://github.com/fatih/color/blob/master/doc.go |
|
@fatih ah, I see... I'll update it today 😄 |
|
I added |
|
Thanks @rhysd, nice update 👍 |
Hi,
I added
Hi*()helpers (likeHiRed()) for hi-intensity colors as well as normal colors.I added them because only 8 of 16 colors have helpers. I feel hi-intensity colors are as popular as normal colors and used in many places. At least, I wanted to use hi-black for making a text not stand out, and hi-white for making a text be noticeable.