component: export-based interface #401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c29e7c to
04228f6
Compare
JakeChampion
reviewed
Feb 2, 2023
Comment on lines
+489
to
+492
|
|
||
| export fastly-runtime: interface { | ||
| serve-sync: func() -> () | ||
| } |
There was a problem hiding this comment.
non-blocking question: Would it be possible to have this in a different file which imports the xqd world?
The reason I ask is because I think it would be good to keep the xqd definition in a different file to help make it clear that the xqd definitions are not ours (also we should probably name it compute-at-edge instead of xqd 🙈 )
There was a problem hiding this comment.
Agreed, we could even explicitly name it exerpimental-compute-at-edge or something to indicate it's undergoing change.
|
Will close this out, to rather leave it to @elliottt if they want to implement something along these lines or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns an exported function for the component build to run the end-to-end component service as a fully encapsulated function call.