Close queue #16
Merged
Close queue #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Jul 10, 2017
Member
mcollina
left a comment
There was a problem hiding this comment.
We should also expose this if an instance is passed in.
| Boot.prototype.onClose = function (func) { | ||
| this._closeQ.push(func, err => { | ||
| if (err) this._error = err | ||
| }) |
Member
There was a problem hiding this comment.
I think we should call unshift() here. More or less, the latest you register a shutdown part, the sooner it will be executed. This is the inverse of the start phase.
mcollina
approved these changes
Jul 10, 2017
Member
mcollina
left a comment
There was a problem hiding this comment.
The close bit on the instance might need a unit test.
Apart from this, LGTM as semver-major.
Member
Author
Why semver major? |
Member
|
adding the new properties to the instance is. |
Member
Author
|
Ok I got you, it is not a major change for avvio itself, but it is for the apps that are using it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we introduce a new queue to handle the shutdown procedure, following the avvio style!
onCloseto add new functions to execute.closeto start the processRelated: fastify/fastify#123
Feedbacks?