-
-
Notifications
You must be signed in to change notification settings - Fork 44
After/Ready error handling #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <a name="after"></a> | ||
|
|
||
| ### app.after(func([context], [done]), [cb]) | ||
| ### app.after(func(error, [context], [done]), [cb]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think after() should be called with an error at all. We should bail off the plugin loading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not, in this way the user can handle the error inside the after.
Example:
If plugin 1 fails => load plugin 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should be in the register callback, not in after IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, but at the moment this is the behaviour:
test('error', (t) => {
t.plan(2)
const server = { my: 'server' }
const app = boot(server)
app.use(function (s, opts, done) {
done(new Error('err'))
}, err => {
t.ok(err)
app.use(function (s, opts, done) {
done()
})
})
app.ready(function (err) {
t.ok(err)
})
})As you can see, we have not that capability, because the error will arrive to the ready callback in every case.
With after I can "block" that error ina specific point, as you can see here:
test('error', (t) => {
t.plan(3)
const server = { my: 'server' }
const app = boot(server)
app.use(function (s, opts, done) {
done(new Error('err'))
}, err => {
t.ok(err)
})
app.after(function (err) {
t.ok(err)
app.use(function (s, opts, done) {
done()
})
})
app.ready(function (err) {
t.error(err)
})
})This is why yesterday I was saying that we should raise the error in the ready callback only if the error is not handled in the use callback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for this behavior you are describing right know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't understand, do you want me to implement this behaviour?
This is why yesterday I was saying that we should raise the error in the ready callback only if the error is not handled in the use callback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why yesterday I was saying that we should raise the error in the ready callback only if the error is not handled in the use callback.
yes.
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implementation of the discussion done in fastify/fastify#59.