Skip to content

Skip override #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2017
Merged

Skip override #11

merged 4 commits into from
Mar 19, 2017

Conversation

@delvedor
Copy link
Member

@delvedor delvedor commented Mar 18, 2017 •
edited
Loading

In the previous PR (#9) we added the ovverride support to create a plugin inheritance chain.
Sometimes, for some reason, the user needs to disable the override if he has set one.

With this PR we support that.

Example:

const server = { my: 'server' }
const app = boot(server)

app.override = function (s) {
  return Object.create(s)
}

first[Symbol.for('skip-override')] = true
app.use(first)

function first (s, opts, cb) {
  // some code
  cb()
}

If this is 👍 for you, I can proceed to update the docs.

mcollina
mcollina requested changes Mar 18, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs :).

@mcollina mcollina merged commit eacf5ad into master Mar 19, 2017
@mcollina mcollina deleted the skip-override branch March 19, 2017 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@delvedor @mcollina