Skip to content

docs: improve missing data error #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ST-DDT merged 6 commits into from
Feb 28, 2025
Merged

docs: improve missing data error #3406

ST-DDT merged 6 commits into from
Feb 28, 2025
+10 −3

Conversation

@ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 19, 2025 •
edited
Loading

Fixed #3405

Improves the error message for missing data by adding a hint about potentially missing locales.

Preview:

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Feb 19, 2025
@ST-DDT ST-DDT added this to the vAnytime milestone Feb 19, 2025
@ST-DDT ST-DDT requested review from a team February 19, 2025 22:52
@ST-DDT ST-DDT self-assigned this Feb 19, 2025
@netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 79803b5
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67c162c485ec1d0008913076
😎 Deploy Preview https://deploy-preview-3406.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT mentioned this pull request Feb 19, 2025
Closed
10 tasks
@codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (dce28d6) to head (79803b5).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3406   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      216972   216972           
  Branches      944      944           
=======================================
  Hits       216917   216917           
  Misses         55       55
Files with missing lines Coverage Δ
src/faker.ts 100.00% <ø> (ø)
src/internal/locale-proxy.ts 100.00% <ø> (ø)

@matthewmayer
Copy link
Contributor

matthewmayer commented Feb 20, 2025

In the example at https://fakerjs.dev/guide/localization.html#handling-missing-data-errors perhaps we could add base to the fixed version in the example as well as en?

ejcheng
ejcheng reviewed Feb 20, 2025
View reviewed changes
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 20, 2025

In the example at fakerjs.dev/guide/localization.html#handling-missing-data-errors perhaps we could add base to the fixed version in the example as well as en?

Fixed: https://deploy-preview-3406.fakerjs.dev/guide/localization.html#handling-missing-data-errors

@ST-DDT ST-DDT requested review from a team and ejcheng February 20, 2025 09:24
@terrymun
Copy link

terrymun commented Feb 24, 2025

Thanks for improving the docs @ST-DDT ❤️

@ST-DDT ST-DDT merged commit 41ebbbb into next Feb 28, 2025
23 checks passed
@ST-DDT ST-DDT deleted the docs/missing-data-error-improvements branch February 28, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

@ST-DDT ST-DDT

Labels

c: docs Improvements or additions to documentation p: 1-normal Nothing urgent

Projects

None yet

Milestone

vAnytime

Development

Successfully merging this pull request may close these issues.

Custom faker instance with en locale cannot generate system variables

5 participants

@ST-DDT @matthewmayer @terrymun @ejcheng