infra(comment-issue): fix display of thumbs up emoji #3444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3444 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2817 2817
Lines 217494 217494
Branches 953 952 -1
=======================================
Hits 217439 217439
Misses 55 55 🚀 New features to boost your workflow:
|
matthewmayer
approved these changes
Mar 22, 2025
Shinigami92
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the thumbs up emoji on out automatic feature replies were not rendered correctly anymore:
Here are some references:
Apparently, the Markdown render requires a space in front and after a emoji reference:
(:+1:)( :+1: )This have to have changed during the last years, since it worked as expected when we introduced the automatic reply: #2041 (comment)