Skip to content

fix: drop jsonfield dependency and use builtin JSONField #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix: drop jsonfield dependency and use builtin JSONField #180

merged 3 commits into from
Feb 10, 2025

Conversation

obdulia-losantos
Copy link
Contributor

name: Drop jsonfield
about: Drops jsonfield dependency
assignees: fabiocaccamo

Describe your changes
Dropped unmaintained jsonfield field and replaced jsonfield.JSONField with django.db.models.JSONField class.

Addresses second option indicated in PR #179

Related issue
#178

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@obdulia-losantos obdulia-losantos mentioned this pull request Feb 7, 2025
Closed
3 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (bdb4312) to head (066609f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   85.41%   85.34%   -0.07%     
==========================================
  Files          21       21              
  Lines         432      430       -2     
==========================================
- Hits          369      367       -2     
  Misses         63       63
Flag Coverage Δ
unittests 85.34% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obdulia-losantos obdulia-losantos marked this pull request as ready for review February 7, 2025 16:31
fabiocaccamo
fabiocaccamo requested changes Feb 10, 2025
View reviewed changes
@fabiocaccamo
Copy link
Owner

@obdulia-losantos thank you for this PR!

@fabiocaccamo fabiocaccamo added enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 10, 2025
fabiocaccamo
fabiocaccamo requested changes Feb 10, 2025
View reviewed changes
Copy link
Owner

@fabiocaccamo fabiocaccamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obdulia-losantos thank you for this PR, general considerations:

  • keep django in requirements.txt but not in pyproject.toml
  • don't remove requirements.txt file
  • completely remove third-party JSONField dependency and references
  • don't add unnecessary migrations

@obdulia-losantos
Copy link
Contributor Author

obdulia-losantos commented Feb 10, 2025 •
edited
Loading

@obdulia-losantos thank you for this PR, general considerations:

  • keep django in requirements.txt but not in pyproject.toml
  • don't remove requirements.txt file
  • completely remove third-party JSONField dependency and references
  • don't add unnecessary migrations

@fabiocaccamo I applied your suggestions but this is the error I have and the reason of deleting the file

https://app.codacy.com/gh/fabiocaccamo/django-extra-settings/pull-requests/180/issues#issue-66e270ae64aeb0e80050b8c315a47edb

@fabiocaccamo
Copy link
Owner

@obdulia-losantos don't worry about the Codacy issue, the important thing is that it passes all the tests.

Perfect, thank you!

@fabiocaccamo fabiocaccamo merged commit 631c6ff into fabiocaccamo:main Feb 10, 2025
33 of 34 checks passed
@obdulia-losantos obdulia-losantos deleted the fix-json-field-2 branch May 1, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabiocaccamo fabiocaccamo fabiocaccamo requested changes

Assignees

@obdulia-losantos obdulia-losantos

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

Open Source
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@obdulia-losantos @fabiocaccamo