fix Panic Internal error: key lacking binding key=Key::Definition( 1:2), key-debug=Definition(ShortIdentifier(1..1)) in lib/binding/bindings.rs #1903 #1904
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a panic (issue #1903) caused by dummy identifiers with empty TextRanges being registered as l-values and later requested from the binding table. The fix adds a guard to filter out ExprNames with empty ranges in the expr_lvalue function.
- Added a guard condition to skip ExprNames with empty TextRanges in
Ast::expr_lvalue - Added a regression test for the specific malformed syntax pattern
(:=).:that triggered the original panic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyrefly/lib/test/simple.rs | Adds regression test for issue #1903 with the pattern that previously caused a panic |
| crates/pyrefly_python/src/ast.rs | Guards expr_lvalue to ignore ExprNames with empty ranges, preventing dummy identifiers from being registered |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
828b508 to
d7a4d3a
Compare
|
@grievejia has imported this pull request. If you are a Meta employee, you can view this in D89686559. |
yangdanny97
approved these changes
Dec 23, 2025
Contributor
yangdanny97
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@grievejia merged this pull request in b4be85d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1903
Guarded Ast::expr_lvalue so it ignores ExprNames whose TextRange is empty, preventing dummy identifiers emitted by the parser from ever being registered as l-values and later requested from the binding table
Test Plan
add a test