Skip to content

Support pre-release version numbers in deploy script #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2024
Merged

Support pre-release version numbers in deploy script #431

merged 4 commits into from
Mar 27, 2024

Conversation

@afterdusk
Copy link
Member

@afterdusk afterdusk commented Mar 27, 2024

Updates our deploy script to handle pre-release version strings. Without it, our deploy script currently hangs with the following log:

...
Available akd_core versions: "0.8.0" "0.8.2" "0.8.3" "0.8.4" "0.8.5" "0.8.6" "0.8.7" "0.8.8" "0.8.9" "0.9.0" "0.10.0" "0.11.0" "0.12.0-pre.1" 
Expected version of akd_core (0.12.0) is not yet published. Retrying after a wait
...

Also bumps our version to 0.12.0-pre.2 to re-attempt deploy.

Regex Test

% echo "0.11" | grep -o '[0-9]\.[0-9\.]\+\(-pre\.[0-9]\+\)\?'  
0.11

% echo "0.11.1" | grep -o '[0-9]\.[0-9\.]\+\(-pre\.[0-9]\+\)\?' 
0.11.1

% echo "0.11.11" | grep -o '[0-9]\.[0-9\.]\+\(-pre\.[0-9]\+\)\?' 
0.11.11

% echo "0.11-pre.1" | grep -o '[0-9]\.[0-9\.]\+\(-pre\.[0-9]\+\)\?' 
0.11-pre.1

% echo "0.11.0-pre.12" | grep -o '[0-9]\.[0-9\.]\+\(-pre\.[0-9]\+\)\?' 
0.11.0-pre.12

@afterdusk afterdusk requested review from kevinlewi and slawlor March 27, 2024 01:36
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 27, 2024
kevinlewi
kevinlewi approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (493c9bc) to head (274bb88).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   88.58%   88.57%   -0.02%     
==========================================
  Files          39       39              
  Lines        9077     9077              
==========================================
- Hits         8041     8040       -1     
- Misses       1036     1037       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afterdusk afterdusk merged commit 0094631 into facebook:main Mar 27, 2024
@afterdusk afterdusk deleted the deploy-script branch March 27, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinlewi kevinlewi kevinlewi approved these changes

@slawlor slawlor Awaiting requested review from slawlor

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@afterdusk @codecov-commenter @kevinlewi @facebook-github-bot