feat: update error loc to key in no-dupe-class-members
#20259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lumirlumir
approved these changes
Oct 30, 2025
Member
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like another review before merging.
mdjermanovic
approved these changes
Oct 30, 2025
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for one more day if anyone else would like to review it.
no-dupe-class-membersno-dupe-class-members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated the error location of
no-dupe-class-membersrule to the identifier instead of the whole expression so that it will only highlight the place where we need to change the code to fix the error.Is there anything you'd like reviewers to focus on?
Similar to PR #20258