Skip to content

Conversation

@kitsunekyo
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The docs pages extend/plugin-migration-flat-config#backwards-compatibility and extend/plugins#backwards-compatibility-for-legacy-configs both recommended different namings for legacy configurations.

While the former page called for a suffix -legacy, the latter recommends a prefix with legacy-.

The docs line recommending legacy- as prefix had a more recent commit (7 months vs 2 years) and both eslint-plugin-vitest and eslint-plugin-package-json use this naming, so I opted to keep this version.

Is there anything you'd like reviewers to focus on?

Please check whether the naming convention is the one you want to go with.

@kitsunekyo kitsunekyo requested a review from a team as a code owner October 27, 2025 07:27
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 27, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Oct 27, 2025
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 937f49f
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/690289f1b8a68d00084b30bf
😎 Deploy Preview https://deploy-preview-20250--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kitsunekyo / name: Alex M. Spieslechner (4d23bd5, 937f49f)
  • ✅ login: mdjermanovic / name: Milos Djermanovic (937f49f)

@kitsunekyo kitsunekyo force-pushed the docs/inconsistent-legacy-naming-recommendation branch from 497f5e4 to d499064 Compare October 27, 2025 07:28
@kitsunekyo kitsunekyo force-pushed the docs/inconsistent-legacy-naming-recommendation branch from d499064 to 4d23bd5 Compare October 27, 2025 07:29
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Oct 27, 2025
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 27, 2025
@mdjermanovic
Copy link
Member

Thanks for catching this inconsistency. We should definitely align these recommendations.

Co-authored-by: Milos Djermanovic <[email protected]>
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like @mdjermanovic to verify before merging.

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage Oct 30, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 0f0385f into eslint:main Oct 30, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 30, 2025
@kitsunekyo kitsunekyo deleted the docs/inconsistent-legacy-naming-recommendation branch October 31, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants