Skip to content

Conversation

Pixel998
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR refactors no-misleading-character-class and require-unicode-regexp to use defaultOptions instead of runtime fallbacks.

Is there anything you'd like reviewers to focus on?

@Pixel998 Pixel998 requested a review from a team as a code owner September 15, 2025 02:35
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 15, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Sep 15, 2025
Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 3161316
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68c77b627d27b40008675435

@github-actions github-actions bot added the rule Relates to ESLint's core rules label Sep 15, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Would like another review before merging.

@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 15, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Second Review Needed in Triage Sep 15, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit fee751d into eslint:main Sep 15, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing rule Relates to ESLint's core rules

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants