Skip to content

Conversation

lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Sep 13, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

In this PR, I've added missing location information (such as line, column, endLine, and endColumn) to error objects in the rule tests.

Some rules were missing these properties, so I've included them. (I've only updated the non-deprecated rules.)

With this change, the tests will be more robust.

Is there anything you'd like reviewers to focus on?

N/A

@lumirlumir lumirlumir requested a review from a team as a code owner September 13, 2025 09:59
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 13, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Sep 13, 2025
Copy link

netlify bot commented Sep 13, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit df03f07
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68c5408c8726e200082c2327

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 4821963 into main Sep 13, 2025
30 checks passed
@mdjermanovic mdjermanovic deleted the test-add-loc-information-to-error-objects-in-rule-tests branch September 13, 2025 12:40
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This change is not user-facing

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants