fix: correct no-loss-of-precision
false positives for leading zeros
#20164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What rule do you want to change?
no-loss-of-precision
What change do you want to make (place an "X" next to just one item)?
[ ] Generate more warnings
[X] Generate fewer warnings
[ ] Implement autofix
[ ] Implement suggestions
How will the change be implemented (place an "X" next to just one item)?
[ ] A new option
[X] A new default behavior
[ ] Other
Please provide some example code that this change will affect:
Playground link
What does the rule currently do for this code?
Report errors.
What will the rule do after it's changed?
Report no errors.
What changes did you make? (Give an overview)
Non-strict mode JS allows base-10 number literals to be preceded by zeros. This PR patches the rule to account for the case where more than one zero precedes an integer to determine its correct value.
Other cases, such as when an integer is preceded by a single zero, or when a non-integer value is preceded by one or more zeros are already handled correctly.
Is there anything you'd like reviewers to focus on?