fix!: remove ecmaFeatures.globalReturn
#20145
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 task
mdjermanovic
reviewed
Oct 1, 2025
mdjermanovic
reviewed
Oct 6, 2025
mdjermanovic
reviewed
Oct 8, 2025
mdjermanovic
reviewed
Oct 8, 2025
1 task
mdjermanovic
approved these changes
Oct 13, 2025
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Would like a second review.
Member
|
As noted in eslint/js#525 (comment), we will revisit the decision to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
The next release of
espreewill removeecmaFeatures.globalReturn. Top-level return statements are now allowed viasourceType: "commonjs", and specifyingglobalReturnwill throw an error.What changes did you make? (Give an overview)
globalReturnfrom parser options, types, etc.sourceType === "commonjs"instead ofglobalReturn.globalReturnglobalReturnRefs eslint/js#692
Is there anything you'd like reviewers to focus on?