fix: correct types for no-restricted-imports
rule
#20034
Merged
+7
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes types for the
patterns
option of theno-restricted-imports
rule.What changes did you make? (Give an overview)
importNames
,importNamePattern
,allowImportNames
orallowImportNamePattern
specified. For example,"no-restricted-imports": [2, { patterns: [{ group: ["foo"] }] }]
was invalid before this change.importNames
andimportNamePattern
can be specified in the same object. For example,"no-restricted-imports": [2, { patterns: [{ group: ["foo"], importNames: ["bar"], importNamePattern: "baz" }] }]
was invalid before this change."no-restricted-imports": [2, { patterns: [{ group: ["foo"], importNames: ["bar"]}, "bar"] }]
was valid before this change.Is there anything you'd like reviewers to focus on?