Skip to content

feat!: drop support for jiti < 2.2.0 #20016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fasttime merged 7 commits into from
Nov 8, 2025
Merged

feat!: drop support for jiti < 2.2.0 #20016

fasttime merged 7 commits into from
Nov 8, 2025

Conversation

@michaelfaith
Copy link
Contributor

@michaelfaith michaelfaith commented Aug 18, 2025 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofix to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain: removed support for jiti < 2.2.0

What changes did you make? (Give an overview)

This change removes support for jiti < 2.2.0. Now, if you're wanting to use a TypeScript config without Node's native type stripping, you must have at least version 2.2.0 of jiti installed.

Fixes #19765

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Aug 18, 2025
@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Aug 18, 2025
@netlify
Copy link

netlify bot commented Aug 18, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit efd1ffc
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/690f4f95b62d3f0008c5202d

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 18, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the core Relates to ESLint's core APIs and features label Aug 18, 2025
@michaelfaith michaelfaith marked this pull request as ready for review August 18, 2025 22:32
@michaelfaith michaelfaith requested a review from a team as a code owner August 18, 2025 22:32
@michaelfaith michaelfaith marked this pull request as draft August 18, 2025 22:52
@fasttime fasttime moved this from Needs Triage to Triaging in Triage Aug 19, 2025
@fasttime fasttime moved this from Triaging to Blocked in Triage Aug 19, 2025
@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 19, 2025
fasttime
fasttime reviewed Aug 19, 2025
View reviewed changes
@fasttime fasttime added this to v10.0.0 Aug 19, 2025
@fasttime fasttime moved this to Implementing in v10.0.0 Aug 19, 2025
@fasttime
Copy link
Member

fasttime commented Aug 19, 2025

The CI failure seems unrelated.

@michaelfaith
Copy link
Contributor Author

michaelfaith commented Aug 19, 2025

The CI failure seems unrelated.

Indeed. It appears this is failing in all the workflow runs now. (e.g. https://github.com/eslint/eslint/actions/runs/17082032100)

@fasttime
Copy link
Member

fasttime commented Aug 20, 2025

The CI failure seems unrelated.

Indeed. It appears this is failing in all the workflow runs now. (e.g. https://github.com/eslint/eslint/actions/runs/17082032100)

The failure should have been fixed in 6c07420.

fasttime
fasttime previously approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! It could take some time until this is merged because the preparations for ESLint v10 aren't quite done yet. Since this is a feature, it will also need another review.

@michaelfaith
Copy link
Contributor Author

michaelfaith commented Aug 20, 2025

Sounds good! Should I just leave it in draft until then?

@fasttime
Copy link
Member

fasttime commented Aug 20, 2025

Should I just leave it in draft until then?

Yes, we will undraft this after retargeting to a v10.x branch.

@mdjermanovic mdjermanovic removed this from v10.0.0 Aug 29, 2025
@mdjermanovic
Copy link
Member

mdjermanovic commented Nov 7, 2025

@michaelfaith can you please fix merge conflicts, and also update the v10 migration guide in this PR?

https://github.com/eslint/eslint/blob/main/docs/src/use/migrate-to-10.0.0.md

We plan to include this change in ESLint v10.0.0-alpha.0, which is scheduled for November 14th.

@mdjermanovic
Copy link
Member

mdjermanovic commented Nov 7, 2025

Note: the PR should still target the main branch.

@michaelfaith
Copy link
Contributor Author

michaelfaith commented Nov 7, 2025

Sure thing. I'll take care of it this weekend.

@michaelfaith
feat!: drop support for jiti < 2.2.0
ee91959 
This change removes support for `jiti` `< 2.2.0`.  Now, if you're wanting to use a TypeScript config without Node's native type stripping, you must have at least version `2.2.0` of `jiti` installed.
@michaelfaith
updated for pr feedback
1297e0f
@michaelfaith
fix formatting
4a6a4fd
@michaelfaith
Copy link
Contributor Author

michaelfaith commented Nov 8, 2025

@mdjermanovic I've rebased and resolved the conflicts. Also, added a section to the migration doc. Let me know what you think.

fasttime
fasttime reviewed Nov 8, 2025
View reviewed changes
@fasttime fasttime moved this from Blocked to Implementing in Triage Nov 8, 2025
@fasttime fasttime marked this pull request as ready for review November 8, 2025 07:04
@fasttime
Copy link
Member

fasttime commented Nov 8, 2025

I've marked the PR as ready for review.

mdjermanovic
mdjermanovic reviewed Nov 8, 2025
View reviewed changes
michaelfaith and others added 2 commits November 8, 2025 07:47
@michaelfaith @fasttime
Update docs/src/use/migrate-to-10.0.0.md
af9e29f 
correct latest jiti version

Co-authored-by: Francesco Trotta <[email protected]>
@michaelfaith
fix test merge issue
efd1ffc
mdjermanovic
mdjermanovic approved these changes Nov 8, 2025
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @fasttime to verify.

fasttime
fasttime approved these changes Nov 8, 2025
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 523c076 into eslint:main Nov 8, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fasttime fasttime fasttime approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible contributor pool core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change Request: remove support for jiti < 2.2.0

3 participants

@michaelfaith @fasttime @mdjermanovic