Skip to content

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Removes tests/lib/eslint/eslint.config.js fixture config file. When lookup from config file becomes default behavior in v10, this config would apply to files in tests/lib/eslint/ when linting this project, which is not what we want. Also, it seems that VSCode by default already applies the nearest config file, so I was always getting wrong lint errors when editing tests/lib/eslint/eslint.js because VSCode used this config instead of the root one.

What changes did you make? (Give an overview)

Removed tests/lib/eslint/eslint.config.js and updated tests that were using it.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner September 2, 2025 15:43
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Sep 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 2, 2025
Copy link

netlify bot commented Sep 2, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 167fb0e
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68b710a32f192800096607d0

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 7055764 into main Sep 3, 2025
30 checks passed
@nzakas nzakas deleted the remove-fixture-config branch September 3, 2025 14:57
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This change is not user-facing

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants