Skip to content

fix: update uncloneable options error message #20059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
Merged

fix: update uncloneable options error message #20059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2466234
refactor: updated uncloneable-options error message to give more clarity
cosmic-pixel-painter Aug 30, 2025
a8fd312
updated tests to match error message change
cosmic-pixel-painter Aug 30, 2025
b52ae57
fix: language clean-up for clarity
cosmic-pixel-painter Sep 2, 2025
5fc9d1a
Merge branch 'main' into uncloneable-options-error-msg-suggestion
cosmic-pixel-painter Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/eslint/eslint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ function validateOptionCloneability(options) {
})
.sort();
const error = new TypeError(
`The ${uncloneableOptionKeys.length === 1 ? "option" : "options"} ${new Intl.ListFormat("en-US").format(uncloneableOptionKeys.map(key => `"${key}"`))} cannot be cloned. When concurrency is enabled, all options must be cloneable. Remove uncloneable options or use an options module.`,
`The ${uncloneableOptionKeys.length === 1 ? "option" : "options"} ${new Intl.ListFormat("en-US").format(uncloneableOptionKeys.map(key => `"${key}"`))} cannot be cloned. When concurrency is enabled, all options must be cloneable values (JSON values). Remove uncloneable options or use an options module.`,
);
error.code = "ESLINT_UNCLONEABLE_OPTIONS";
throw error;
Expand Down
12 changes: 6 additions & 6 deletions tests/lib/eslint/eslint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ describe("ESLint", () => {
constructor: TypeError,
code: "ESLINT_UNCLONEABLE_OPTIONS",
message:
'The options "baseConfig", "fix", and "plugins" cannot be cloned. When concurrency is enabled, all options must be cloneable. Remove uncloneable options or use an options module.',
'The options "baseConfig", "fix", and "plugins" cannot be cloned. When concurrency is enabled, all options must be cloneable values (JSON values). Remove uncloneable options or use an options module.',
},
);
});
Expand All @@ -445,7 +445,7 @@ describe("ESLint", () => {
constructor: TypeError,
code: "ESLINT_UNCLONEABLE_OPTIONS",
message:
'The option "ruleFilter" cannot be cloned. When concurrency is enabled, all options must be cloneable. Remove uncloneable options or use an options module.',
'The option "ruleFilter" cannot be cloned. When concurrency is enabled, all options must be cloneable values (JSON values). Remove uncloneable options or use an options module.',
},
);
});
Expand Down Expand Up @@ -9778,13 +9778,13 @@ describe("ESLint", () => {
const optionsSrc = `
import assert from "node:assert";
import { isMainThread } from "node:worker_threads";

if (!isMainThread) {
if (process.env.ESLINT_TEST_ENV !== "test") {
assert.fail("Environment variable ESLINT_TEST_ENV is not set as expected in worker threads.");
}
}

export default {
concurrency: 2,
cwd: ${JSON.stringify(fixtureDir)},
Expand All @@ -9803,11 +9803,11 @@ describe("ESLint", () => {
it("should propagate environment variables from worker threads to the controlling thread", async () => {
const optionsSrc = `
import { isMainThread } from "node:worker_threads";

if (!isMainThread) {
process.env.ESLINT_TEST_ENV = "test";
}

export default {
concurrency: 2,
cwd: ${JSON.stringify(fixtureDir)},
Expand Down
Loading