Skip to content

feat: implement suggestions for no-empty-function #20057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

feat: implement suggestions for no-empty-function #20057

merged 1 commit into from
Sep 3, 2025

Conversation

jaymarvelz
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Added fixable suggestions to insert /* empty */ inside empty function bodies.
  • Updated tests

Closes #20055

Is there anything you'd like reviewers to focus on?

@jaymarvelz jaymarvelz requested a review from a team as a code owner August 30, 2025 07:14
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Aug 30, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 2df4645
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68b2a4ee80cd2d000806d039

@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Aug 30, 2025
@eslint-github-bot eslint-github-bot bot mentioned this pull request Aug 30, 2025
Closed
1 task
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Aug 30, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Aug 30, 2025
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Aug 30, 2025
mdjermanovic
mdjermanovic approved these changes Aug 30, 2025
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for a second review.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Aug 30, 2025
fasttime
fasttime approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 42761fa into eslint:main Sep 3, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Sep 3, 2025
nzakas pushed a commit that referenced this pull request Sep 23, 2025
@jaymarvelz @nzakas
feat: implement suggestions for no-empty-function (#20057)
04d3057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fasttime fasttime fasttime approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature This change adds a new feature to ESLint rule Relates to ESLint's core rules

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule Change: Implement suggestions for no-empty-function

3 participants

@jaymarvelz @fasttime @mdjermanovic