Skip to content

Conversation

jaymarvelz
Copy link
Contributor

@jaymarvelz jaymarvelz commented Aug 30, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Added fixable suggestions to insert /* empty */ inside empty static blocks.
  • Updated highlighting so that only the opening and closing braces {} are marked, instead of the entire static block.

Closes #20054

Is there anything you'd like reviewers to focus on?

@jaymarvelz jaymarvelz requested a review from a team as a code owner August 30, 2025 05:56
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Aug 30, 2025
Copy link

netlify bot commented Aug 30, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit e0cc73c
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68b2928516e24b00087cb709

@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Aug 30, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Aug 30, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Aug 30, 2025
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Aug 30, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for a second review.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Aug 30, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 102f444 into eslint:main Sep 3, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature This change adds a new feature to ESLint rule Relates to ESLint's core rules

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Rule Change: Implement suggestions for no-empty-static-block

3 participants