Skip to content

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jul 1, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

refs: #17856, eslint/workflows#1

Is there anything you'd like reviewers to focus on?

eslint/workflows#1 should be merged first.

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 1, 2025
Copy link

netlify bot commented Jul 1, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit d1ec3da
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68c5814a0494300008680400
😎 Deploy Preview https://deploy-preview-19907--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Jul 1, 2025
@aladdin-add aladdin-add moved this from Needs Triage to Implementing in Triage Jul 1, 2025
Copy link

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@aladdin-add aladdin-add marked this pull request as ready for review September 13, 2025 14:36
@aladdin-add aladdin-add requested a review from a team as a code owner September 13, 2025 14:36
@aladdin-add
Copy link
Member Author

I've tested it in a fork, seems working fine: aladdin-add#12. 🎉

@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 13, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🎉

Would like another review before merging.

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage Sep 13, 2025
@lumirlumir lumirlumir requested a review from a team September 14, 2025 05:24
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit bac82a2 into main Sep 15, 2025
30 checks passed
@nzakas nzakas deleted the ci/renovate branch September 15, 2025 15:13
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Sep 15, 2025
nzakas pushed a commit that referenced this pull request Sep 23, 2025
ci: centralize renovate config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process Stale

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants