Skip to content

test: switch to Linter.Config in ESLintRules type tests #19977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

test: switch to Linter.Config in ESLintRules type tests #19977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 38 additions & 35 deletions tests/lib/types/types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1824,35 +1824,40 @@ for (const result of results) {

// #region ESLintRules

let eslintConfig: Linter.LegacyConfig<ESLintRules>;
let eslintConfig: Linter.Config<ESLintRules>[];

eslintConfig = {
rules: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks clean!

"capitalized-comments": [2, "always", { ignorePattern: "const|let" }],
"no-promise-executor-return": [2, { allowVoid: true }],
"sort-keys": [2, "asc", { allowLineSeparatedGroups: true }],
eslintConfig = [
{
rules: {
"capitalized-comments": [
2,
"always",
{ ignorePattern: "const|let" },
],
"no-promise-executor-return": [2, { allowVoid: true }],
"sort-keys": [2, "asc", { allowLineSeparatedGroups: true }],
},
},
overrides: [
{
files: "*.json",
rules: {
"max-len": 0,
},
{
files: ["**/*.json"],
rules: {
"no-restricted-syntax": 0,
},
{
files: "*.ts",
rules: {
"@typescript-eslint/no-invalid-void-type": [
2,
{ allowAsThisParameter: true },
],
},
},
{
files: ["**/*.ts"],
rules: {
"@typescript-eslint/no-invalid-void-type": [
2,
{ allowAsThisParameter: true },
],
},
],
};
},
];

eslintConfig.rules; // $ExpectType Partial<ESLintRules> | undefined
eslintConfig.overrides?.[0].rules; // $ExpectType Partial<ESLintRules> | undefined
(configIndex: number) => {
eslintConfig[configIndex].rules; // $ExpectType Partial<ESLintRules> | undefined
};

interface TSLinterRules {
"@typescript-eslint/no-invalid-void-type"?: Linter.RuleEntry<
Expand All @@ -1865,19 +1870,17 @@ interface TSLinterRules {
>;
}

const eslintConfig2: Linter.LegacyConfig<
ESLintRules,
ESLintRules & TSLinterRules
> = eslintConfig;
const eslintConfig2: Linter.Config<ESLintRules & TSLinterRules>[] =
eslintConfig;

eslintConfig2.rules; // $ExpectType Partial<ESLintRules> | undefined
eslintConfig2.overrides?.[1].rules; // $ExpectType Partial<ESLintRules & TSLinterRules> | undefined

const eslintConfig3: Linter.LegacyConfig<ESLintRules & TSLinterRules> =
eslintConfig2;
(configIndex: number) => {
eslintConfig2[configIndex].rules; // $ExpectType Partial<ESLintRules & TSLinterRules> | undefined
};

eslintConfig3.rules; // $ExpectType Partial<ESLintRules & TSLinterRules> | undefined
eslintConfig3.overrides?.[1].rules; // $ExpectType Partial<ESLintRules & TSLinterRules> | undefined
(configIndex: number) => {
const rules: Partial<Linter.RulesRecord> | undefined =
eslintConfig2[configIndex].rules;
};

// #endregion

Expand Down
Loading