feat: add eslint-plugin-regexp to eslint-config-eslint base config #19951

Pixel998 · 2025-07-18T07:42:46Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Added eslint-plugin-regexp as a dependency to eslint-config-eslint.
Extended the base config to include eslint-plugin-regexp's recommended rules.
Updated the export in base.js to spread the new regexp config.

Fixes #19945

Is there anything you'd like reviewers to focus on?

netlify · 2025-07-18T07:42:51Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`5cf1b2c`
🔍 Latest deploy log	https://app.netlify.com/projects/docs-eslint/deploys/6899c951220f410008b5b72b

github-actions · 2025-07-28T22:37:44Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

nzakas

LGTM, nice work!

Would like another review before merging.

fasttime · 2025-08-05T06:21:08Z

Shall we release this feature as a breaking change? Otherwise other repos that use "eslint-config-eslint": "^11.0.0" could have their build suddenly broken. @eslint/eslint-team?

docs/tools/markdown-it-rule-example.js

lib/config/flat-config-schema.js

lib/rules/indent-legacy.js

lib/rules/no-mixed-spaces-and-tabs.js

mdjermanovic · 2025-08-05T14:33:19Z

Shall we release this feature as a breaking change? Otherwise other repos that use "eslint-config-eslint": "^11.0.0" could have their build suddenly broken.

Yes, we should select major as RELEASE_TYPE when releasing eslint-config-eslint with these changes. But the tag should remain non-breaking, otherwise it would bump eslint's major version when releasing the eslint package.

lib/rules/no-mixed-spaces-and-tabs.js

packages/eslint-config-eslint/package.json

packages/eslint-config-eslint/base.js

docs/tools/markdown-it-rule-example.js

lib/config/flat-config-schema.js

mdjermanovic

LGTM, thanks! Leaving open for @nzakas and @fasttime to re-review.

fasttime

LGTM, thanks.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`9.33.0` -> `9.34.0`](https://renovatebot.com/diffs/npm/eslint/9.33.0/9.34.0) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v9.34.0`](https://github.com/eslint/eslint/releases/tag/v9.34.0) [Compare Source](eslint/eslint@v9.33.0...v9.34.0) #### Features - [`0bb777a`](eslint/eslint@0bb777a) feat: multithread linting ([#19794](eslint/eslint#19794)) (Francesco Trotta) - [`43a5f9e`](eslint/eslint@43a5f9e) feat: add eslint-plugin-regexp to eslint-config-eslint base config ([#19951](eslint/eslint#19951)) (Pixel998) #### Bug Fixes - [`9b89903`](eslint/eslint@9b89903) fix: default value of accessor-pairs option in rule.d.ts file ([#20024](eslint/eslint#20024)) (Tanuj Kanti) - [`6c07420`](eslint/eslint@6c07420) fix: fix spurious failure in neostandard integration test ([#20023](eslint/eslint#20023)) (Kirk Waiblinger) - [`676f4ac`](eslint/eslint@676f4ac) fix: allow scientific notation with trailing zeros matching exponent ([#20002](eslint/eslint#20002)) (Sweta Tanwar) #### Documentation - [`0b4a590`](eslint/eslint@0b4a590) docs: make rulesdir deprecation clearer ([#20018](eslint/eslint#20018)) (Domenico Gemoli) - [`327c672`](eslint/eslint@327c672) docs: Update README (GitHub Actions Bot) - [`bf26229`](eslint/eslint@bf26229) docs: Fix typo in core-concepts/index.md ([#20009](eslint/eslint#20009)) (Tobias Hernstig) - [`2309327`](eslint/eslint@2309327) docs: fix typo in the "Configuring Rules" section ([#20001](eslint/eslint#20001)) (ghazi-git) - [`2b87e21`](eslint/eslint@2b87e21) docs: \[no-else-return] clarify sample code. ([#19991](eslint/eslint#19991)) (Yuki Takada (Yukinosuke Takada)) - [`c36570c`](eslint/eslint@c36570c) docs: Update README (GitHub Actions Bot) #### Chores - [`f19ad94`](eslint/eslint@f19ad94) chore: upgrade to `@eslint/[email protected]` ([#20030](eslint/eslint#20030)) (Francesco Trotta) - [`b48fa20`](eslint/eslint@b48fa20) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`4bce8a2`](eslint/eslint@4bce8a2) chore: package.json update for eslint-config-eslint release (Jenkins) - [`0c9999c`](eslint/eslint@0c9999c) refactor: prefer default options in `grouped-accessor-pairs` ([#20028](eslint/eslint#20028)) (루밀LuMir) - [`d503f19`](eslint/eslint@d503f19) ci: fix `stale.yml` ([#20010](eslint/eslint#20010)) (루밀LuMir) - [`e2dc67d`](eslint/eslint@e2dc67d) ci: centralize `stale.yml` ([#19994](eslint/eslint#19994)) (루밀LuMir) - [`7093cb8`](eslint/eslint@7093cb8) ci: bump actions/checkout from 4 to 5 ([#20005](eslint/eslint#20005)) (dependabot\[bot]) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.robbevp.be/robbevp/website-robbevanpetegem/pulls/495 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

feat: add eslint-plugin-regexp to eslint-config-eslint base config

1a0ae1b

Pixel998 requested a review from a team as a code owner July 18, 2025 07:42

github-project-automation bot added this to Triage Jul 18, 2025

github-project-automation bot moved this to Needs Triage in Triage Jul 18, 2025

eslint-github-bot bot added the feature This change adds a new feature to ESLint label Jul 18, 2025

Pixel998 marked this pull request as draft July 18, 2025 08:02

nzakas moved this from Needs Triage to Implementing in Triage Jul 28, 2025

github-actions bot added the Stale label Jul 28, 2025

resolve linting errors

aaf6500

github-actions bot added rule Relates to ESLint's core rules cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features labels Aug 4, 2025

Pixel998 marked this pull request as ready for review August 4, 2025 09:38

nzakas added the contributor pool label Aug 4, 2025

nzakas previously approved these changes Aug 4, 2025

View reviewed changes

nzakas moved this from Implementing to Second Review Needed in Triage Aug 4, 2025

github-actions bot removed the Stale label Aug 4, 2025

fasttime reviewed Aug 5, 2025

View reviewed changes

docs/tools/markdown-it-rule-example.js Outdated Show resolved Hide resolved

lib/config/flat-config-schema.js Outdated Show resolved Hide resolved

lib/rules/indent-legacy.js Outdated Show resolved Hide resolved

lib/rules/no-mixed-spaces-and-tabs.js Outdated Show resolved Hide resolved

apply fasttime's suggestions

907e6da

Pixel998 dismissed nzakas’s stale review via 907e6da August 5, 2025 11:45

mdjermanovic reviewed Aug 5, 2025

View reviewed changes

lib/rules/no-mixed-spaces-and-tabs.js Outdated Show resolved Hide resolved

mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 6, 2025

fasttime mentioned this pull request Aug 6, 2025

SyntaxError on regular expression /[\w-$]/u nodejs/node#59378

Closed

revert regex change and suppress false positive

d4f615e

Pixel998 mentioned this pull request Aug 7, 2025

test: resolve flakiness in --mcp flag test #19993

Merged

1 task

mdjermanovic reviewed Aug 10, 2025

View reviewed changes

packages/eslint-config-eslint/package.json Outdated Show resolved Hide resolved

packages/eslint-config-eslint/base.js Show resolved Hide resolved

mdjermanovic reviewed Aug 10, 2025

View reviewed changes

docs/tools/markdown-it-rule-example.js Outdated Show resolved Hide resolved

update eslint-plugin-regexp

4f107b4

mdjermanovic reviewed Aug 11, 2025

View reviewed changes

lib/config/flat-config-schema.js Outdated Show resolved Hide resolved

remove start anchor from plugin member name regex

5cf1b2c

mdjermanovic approved these changes Aug 11, 2025

View reviewed changes

fasttime approved these changes Aug 11, 2025

View reviewed changes

fasttime requested a review from nzakas August 11, 2025 18:55

nzakas approved these changes Aug 14, 2025

View reviewed changes

nzakas merged commit 43a5f9e into eslint:main Aug 14, 2025
31 checks passed

github-project-automation bot moved this from Second Review Needed to Complete in Triage Aug 14, 2025

Uh oh!

feat: add eslint-plugin-regexp to eslint-config-eslint base config #19951

feat: add eslint-plugin-regexp to eslint-config-eslint base config #19951

Conversation

Pixel998 commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint canceled.

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

nzakas left a comment

Choose a reason for hiding this comment

Uh oh!

fasttime commented Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic commented Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

fasttime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Pixel998 commented Jul 18, 2025 •

edited

Loading

netlify bot commented Jul 18, 2025 •

edited

Loading