Skip to content

feat: throw error when column is negative in getIndexFromLoc #19831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025
Merged

feat: throw error when column is negative in getIndexFromLoc #19831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41f4fb3
fix: handle negative column index in `getIndexFromLoc` and add tests
lumirlumir Jun 8, 2025
97b6ede
wip: address comments
lumirlumir Jun 16, 2025
55fb878
wip: add more test cases
lumirlumir Jun 16, 2025
25fd19b
Merge branch 'main' into fix-handle-negative-column-index-in-getindex…
lumirlumir Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/languages/js/source-code/source-code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,12 @@ class SourceCode extends TokenStore {
);
}

if (loc.column < 0) {
throw new RangeError(
`Invalid column number (column ${loc.column} requested).`,
);
}

const lineStartIndex = this.lineStartIndices[loc.line - 1];
const lineEndIndex =
loc.line === this.lineStartIndices.length
Expand Down
15 changes: 15 additions & 0 deletions tests/lib/languages/js/source-code/source-code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2339,6 +2339,21 @@ describe("SourceCode", () => {
});

it("should throw a useful error if `column` is out of range", () => {
assert.throws(
() => sourceCode.getIndexFromLoc({ line: 1, column: -1 }),
"Invalid column number (column -1 requested).",
);

assert.throws(
() => sourceCode.getIndexFromLoc({ line: 1, column: -5 }),
"Invalid column number (column -5 requested).",
);

assert.throws(
() => sourceCode.getIndexFromLoc({ line: 3, column: -1 }),
"Invalid column number (column -1 requested).",
);

assert.throws(
() => sourceCode.getIndexFromLoc({ line: 3, column: 4 }),
/Column number out of range \(column 4 requested, but the length of line 3 is 4\)\./u,
Expand Down
Loading