Skip to content

Conversation

lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented May 29, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Hello,

This PR adds support for a new feature documentation that is currently being implemented in eslint/rewrite#211.

Is there anything you'd like reviewers to focus on?

@lumirlumir lumirlumir requested a review from a team as a code owner May 29, 2025 11:02
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage May 29, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label May 29, 2025
Copy link

netlify bot commented May 29, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 3e0e267
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/684a6263084dfb0008619704
😎 Deploy Preview https://deploy-preview-19795--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nzakas nzakas marked this pull request as draft May 30, 2025 14:52
@nzakas
Copy link
Member

nzakas commented May 30, 2025

Converting to draft because this can't be merged until eslint/rewrite#211 is merged.

@lumirlumir
Copy link
Member Author

Still pending until eslint/rewrite#216 gets merged.

@lumirlumir lumirlumir moved this from Needs Triage to Blocked in Triage Jun 4, 2025
@lumirlumir
Copy link
Member Author

Re-open this PR, since eslint/rewrite#216 has been merged.

@lumirlumir lumirlumir marked this pull request as ready for review June 12, 2025 05:15
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 00e3e6a into main Jun 12, 2025
31 checks passed
@mdjermanovic mdjermanovic deleted the add-support-for-custom-name-parameter-to-include-ignore-file branch June 12, 2025 10:11
@github-project-automation github-project-automation bot moved this from Blocked to Complete in Triage Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants