Skip to content

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix #19611

Is there anything you'd like reviewers to focus on?

Nothing

@snitin315 snitin315 requested a review from a team as a code owner April 9, 2025 06:03
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 9, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 9, 2025
@snitin315 snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 9, 2025
Copy link

netlify bot commented Apr 9, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 3d6f314
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67f60dcdc10d82000882f8a9
😎 Deploy Preview https://deploy-preview-19612--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Apr 9, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit f80b746 into main Apr 9, 2025
32 checks passed
@mdjermanovic mdjermanovic deleted the docs/no-self-compare branch April 9, 2025 12:15
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Bug: no-self-compare should not apply to function return values.

2 participants