Skip to content

Conversation

sethamus
Copy link
Contributor

@sethamus sethamus commented Apr 7, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR adds a new allowObjects option to the no-restricted-properties rule, allowing users to globally restrict a property while making exceptions for specific objects.

Closes #19348

Is there anything you'd like reviewers to focus on?

@sethamus sethamus requested a review from a team as a code owner April 7, 2025 09:25
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Apr 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 7, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Apr 7, 2025
Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 1568954
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67f6434db2db3500083e5613
😎 Deploy Preview https://deploy-preview-19607--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 8, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Apr 8, 2025
mdjermanovic
mdjermanovic previously approved these changes Apr 8, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Since this is a feature, it needs a second review.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Apr 8, 2025
snitin315
snitin315 previously approved these changes Apr 9, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Otherwise, LGTM

@sethamus sethamus dismissed stale reviews from snitin315 and mdjermanovic via 1568954 April 9, 2025 09:52
@mdjermanovic mdjermanovic merged commit 59ba6b7 into eslint:main Apr 9, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Apr 9, 2025
@sethamus sethamus deleted the allowObjects-19348 branch April 17, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature This change adds a new feature to ESLint rule Relates to ESLint's core rules

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Rule Change: excludeObjects parameter for no-restricted-properties

3 participants