Skip to content

Conversation

xbinaryx
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR migrates the sass stylesheets from using the deprecated @import rules to the modern module system (@use ) and upgrades sass to the latest version.

This resolves deprecation warnings (Deprecation Warning [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.) encountered when starting or building the docs.

I verified that the output in _site is the same before and after.

Is there anything you'd like reviewers to focus on?

@xbinaryx xbinaryx requested a review from a team as a code owner March 14, 2025 11:45
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 14, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Mar 14, 2025
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit ef149f1
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67d416dee566810008c6ff60
😎 Deploy Preview https://deploy-preview-19518--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ⭐

@snitin315 snitin315 merged commit 996cfb9 into eslint:main Mar 17, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Mar 17, 2025
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants