Skip to content

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refs https://github.com/eslint/markdown/blob/main/rfcs/configure-file-name-from-block-meta.md#name-uniqueness.

What changes did you make? (Give an overview)

Added tests that verify that processors can return slashes in the code block filename and that such filenames are treated as subpaths.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner February 12, 2025 13:15
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Feb 12, 2025
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit fdf72c1
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67ac9edaad59230008427e9f

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 5fd211d into main Feb 12, 2025
29 of 30 checks passed
@nzakas nzakas deleted the test-processor-subdir branch February 12, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This change is not user-facing

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants