docs: additional checks for rule examples #19358

mdjermanovic · 2025-01-21T22:53:36Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Adds more checks for rule examples:

correct examples should have no lint errors.
incorrect examples should have one or more lint errors reported by the rule, and no other errors.
Inline configurations (/* eslint */) should have valid options for the rule.
languageOptions configurations after :::correct/:::incorrect should be valid.

What changes did you make? (Give an overview)

Updated tools/check-rule-examples.js to run Linter#verify() instead of just parsing and added the checks listed above.
Updated several rule docs files that failed with the new checks.

Is there anything you'd like reviewers to focus on?

netlify · 2025-01-21T22:53:53Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`7f671c6`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/679025723963150008018c45
😎 Deploy Preview	https://deploy-preview-19358--docs-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdjermanovic · 2025-01-21T23:26:42Z

docs/src/rules/consistent-this.md

 Examples of **incorrect** code for this rule with the default `"that"` option, if the variable is not initialized:

-::: incorrect
+::: incorrect { "sourceType": "script" }


This was to make the example "incorrect", but the bug reported in #19244 still exists.

mdjermanovic · 2025-01-21T23:29:33Z

tools/check-rule-examples.js

-                    if (parseError) {
-                        problems.push({
-                            fatal: true,
-                            severity: 2,
-                            message: parseError.message,
-                            line: comment.loc.start.line + codeBlockToken.map[0] + 1,
-                            column: comment.loc.start.column + 1
-                        });


These problems will be reported by Linter#verify() so there's no need for a duplicate check here.

mdjermanovic · 2025-01-21T23:30:08Z

tools/check-rule-examples.js

-            if (error) {
-                const message = `Syntax error: ${error.message}`;
-                const line = codeBlockToken.map[0] + 1 + error.lineNumber;
-                const { column } = error;

-                problems.push({
-                    fatal: false,
-                    severity: 2,
-                    message,
-                    line,
-                    column
-                });
-            }


Parsing errors will be reported by Linter#verify().

fasttime · 2025-01-24T11:12:40Z

tools/check-rule-examples.js

+                        lintMessage.fatal ||
+                        lintMessage.message.includes(`Inline configuration for rule "${title}" is invalid`));
+
+                    if (lintMessages.length === length && !lintMessages.some(lintMessage => lintMessage.fatal)) {


I see why it makes sense to check for fatal messages before adding a non-fatal message, but currently it's still possible to get fatal and non-fatal messages mixed up for the same example because the fatal flag is not really cared about anywhere. For instance:

:::incorrect ```ts ?foo ``` :::

This will produce the output:

3:4 error Nonstandard language tag 'ts': use one of 'javascript', 'js' or 'jsx' 4:1 error Unexpected lint error found: Parsing error: Unexpected token ? ✖ 2 problems (2 errors, 0 warnings)

Where only the second problem is fatal. So if we want to avoid showing non-fatal problems when there are fatal ones maybe it would be better to keep two separate lists for non-fatal and fatal problems respectively, and in the end return only one of the lists from the findProblems call.

Alternatively, we could say that we don't care about the fatal status and just report all lint messages that apply without checking for the fatal flag. This is basically what the existing implementation is doing.

Yes, the idea was to show all lint messages returned from linter.verify(), both fatal and non-fatal except for "normal" lint messages produced by the rule in incorrect examples because they are expected (in fact, required) to exist. plus errors produced by additional checks in this script.

In this case, it felt redundant to add "Incorrect examples should have at least one error reported by the rule" error since the example has parsing errors (a fatal lint message) so the rule wasn't run, and the check fails anyway. There may be other cases where this or other errors produced by the script itself are redundant, this one just seemed easy to remove.

fasttime · 2025-01-25T11:17:12Z

tests/tools/check-rule-examples.js

+                "\x1B[0m   \x1B[2m31:1\x1B[22m  \x1B[31merror\x1B[39m  Example code should contain a configuration comment like /* eslint no-restricted-syntax: \"error\" */\x1B[0m\n" +
+                "\x1B[0m   \x1B[2m41:1\x1B[22m  \x1B[31merror\x1B[39m  Unexpected lint error found: Failed to parse JSON from 'doesn't allow this comment'\x1B[0m\n" +
+                "\x1B[0m   \x1B[2m51:1\x1B[22m  \x1B[31merror\x1B[39m  Unexpected lint error found: Rule \"no-restricted-syntax\" is already configured by another configuration comment in the preceding code. This configuration is ignored\x1B[0m\n" +
+                "\x1B[0m   \x1B[2m51:1\x1B[22m  \x1B[31merror\x1B[39m  Duplicate /* eslint no-restricted-syntax */ configuration comment. Each example should contain only one. Split this example into multiple examples\x1B[0m\n" +


Would it make sense to remove this message from the output as well since the same problem has been already reported by the linter previously?

Suggested change

"\x1B[0m \x1B[2m51:1\x1B[22m \x1B[31merror\x1B[39m Duplicate /* eslint no-restricted-syntax */ configuration comment. Each example should contain only one. Split this example into multiple examples\x1B[0m\n" +

"\x1B[0m \x1B[2m51:1\x1B[22m \x1B[31merror\x1B[39m Duplicate /* eslint no-restricted-syntax */ configuration comment. Each example should contain only one. Split this example into multiple examples\x1B[0m\n" +

I intentionally left this in, although it reports the same kind of problem that linter.verify() already reported, because it provides advice in the context of rule examples, that is to "split this example into multiple examples".

fasttime

LGTM, thanks!

![snyk-top-banner](https://redirect.github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123) <h3>Snyk has created this PR to upgrade @eslint/js from 9.19.0 to 9.20.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released **22 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@eslint/js</b></summary> <ul> <li> <b>9.20.0</b> - <a href="https://redirect.github.com/eslint/eslint/releases/tag/v9.20.0">2025-02-07</a></br><h2>Features</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/e89a54a3090f3503daf5e36b02b0035c993e3fd1"><code>e89a54a</code></a> feat: change behavior of inactive flags (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2821852074" data-permission-text="Title is private" data-url="eslint/eslint#19386" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19386/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19386">#19386</a>) (Milos Djermanovic)</li> </ul> <h2>Bug Fixes</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/91d4d9f62095e302c71595cc04c47073f366315c"><code>91d4d9f</code></a> fix: Bring types in sync with @ eslint/core (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2683913007" data-permission-text="Title is private" data-url="eslint/eslint#19157" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19157/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19157">#19157</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/fa25c7a79edee280f275fbc35b83bcde906d1480"><code>fa25c7a</code></a> fix: Emit warning when empty config file is used (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2828450158" data-permission-text="Title is private" data-url="eslint/eslint#19399" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19399/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19399">#19399</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/31a9fd03d23aecf2b1e0c9b3df27554aff245723"><code>31a9fd0</code></a> fix: Clearer error message for wrong plugin format (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2818949219" data-permission-text="Title is private" data-url="eslint/eslint#19380" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19380/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19380">#19380</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/61d99e38f248f4d9abc09d970c4eebddd1af86ca"><code>61d99e3</code></a> fix: Better error message for unserializable parser (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2821677106" data-permission-text="Title is private" data-url="eslint/eslint#19384" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19384/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19384">#19384</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/db1b9a66e387e573f45885687dfefc04ab2877fe"><code>db1b9a6</code></a> fix: Ensure module scope is checked for references in <code>consistent-this</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2819044020" data-permission-text="Title is private" data-url="eslint/eslint#19383" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19383/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19383">#19383</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/8bcd820f37f2361e4f7261a9876f52d21bd9de8f"><code>8bcd820</code></a> fix: <code>arrow-body-style</code> crash with single-token body (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2815684602" data-permission-text="Title is private" data-url="eslint/eslint#19379" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19379/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19379">#19379</a>) (Milos Djermanovic)</li> </ul> <h2>Documentation</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/b7012c85f3c0f683baeffb6d856faf86c4d41702"><code>b7012c8</code></a> docs: rewrite examples with var using let and const (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2833783439" data-permission-text="Title is private" data-url="eslint/eslint#19407" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19407/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19407">#19407</a>) (Mueez Javaid Hashmi)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/64063765afa5bf29855d996ccabfaa93b19bd458"><code>6406376</code></a> docs: Update README (GitHub Actions Bot)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/350f2b9349bc8d2230cd953c14b77071f2961f47"><code>350f2b9</code></a> docs: rewrite some examples with var using let and const (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2831133301" data-permission-text="Title is private" data-url="eslint/eslint#19404" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19404/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19404">#19404</a>) (Mueez Javaid Hashmi)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/93c325a7a841d0fe4b5bf79efdec832e7c8f805f"><code>93c325a</code></a> docs: rewrite examples with var using let and const (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2827905788" data-permission-text="Title is private" data-url="eslint/eslint#19398" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19398/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19398">#19398</a>) (Mueez Javaid Hashmi)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/56ff4048e053374db39201e7e880bde4c930e19f"><code>56ff404</code></a> docs: replace var with let or const in rules docs (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2825955857" data-permission-text="Title is private" data-url="eslint/eslint#19396" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19396/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19396">#19396</a>) (Daniel Harbrueger)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/4053226996bbdec1ffdef8af1b9d7f5aa4b11b86"><code>4053226</code></a> docs: change <code>sourceType</code> in <code>no-eval</code> examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2825778899" data-permission-text="Title is private" data-url="eslint/eslint#19393" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19393/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19393">#19393</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/1324af027986d655848ee1a9dcb89a527917ea3e"><code>1324af0</code></a> docs: replace var with let and const in rules docs (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2825591567" data-permission-text="Title is private" data-url="eslint/eslint#19392" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19392/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19392">#19392</a>) (Daniel Harbrueger)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/8b87e007bb2ba59b73061d22ef34baffb5656b79"><code>8b87e00</code></a> docs: replace <code>var</code> with <code>const</code> and <code>let</code> in rules (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2823117975" data-permission-text="Title is private" data-url="eslint/eslint#19389" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19389/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19389">#19389</a>) (Tanuj Kanti)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/758c66bc8d83cd4eda9639b0745f0d0fb70f04f4"><code>758c66b</code></a> docs: Explain what frozen rules mean (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2819010049" data-permission-text="Title is private" data-url="eslint/eslint#19382" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19382/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19382">#19382</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/0ef8bb859c988e558683c2d8bd9c9606f22e456c"><code>0ef8bb8</code></a> docs: additional checks for rule examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2802981267" data-permission-text="Title is private" data-url="eslint/eslint#19358" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19358/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19358">#19358</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/58ab2f69d2d4cf9b49bf3fd303795040ec761ebd"><code>58ab2f6</code></a> docs: fix order of installation steps in getting started (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2777974394" data-permission-text="Title is private" data-url="eslint/eslint#19326" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19326/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19326">#19326</a>) (Tanuj Kanti)</li> </ul> <h2>Chores</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/979097a3b4c656e2d9faabd4a52010d6647911f6"><code>979097a</code></a> chore: upgrade @ eslint/[email protected] (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2839104411" data-permission-text="Title is private" data-url="eslint/eslint#19412" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19412/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19412">#19412</a>) (Francesco Trotta)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/031734efcb27e0d800da7ec32f5d5dae55f80564"><code>031734e</code></a> chore: package.json update for @ eslint/js release (Jenkins)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/d4c47c3738f2bf53b4f6a1cf505861b35875ac5f"><code>d4c47c3</code></a> test: avoid empty config warning in test output (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2834930216" data-permission-text="Title is private" data-url="eslint/eslint#19408" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19408/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19408">#19408</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/67dd82ab88d784b6f36e471b6a5c6f64e37f9485"><code>67dd82a</code></a> chore: update dependency @ eslint/json to ^0.10.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2822208573" data-permission-text="Title is private" data-url="eslint/eslint#19387" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19387/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19387">#19387</a>) (renovate[bot])</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/15ac0e182486f32d63171a310050383e15767697"><code>15ac0e1</code></a> chore: add permissions: read-all to stale.yml workflow (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2812916549" data-permission-text="Title is private" data-url="eslint/eslint#19374" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19374/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19374">#19374</a>) (Josh Goldberg ✨)</li> </ul> </li> <li> <b>9.19.0</b> - <a href="https://redirect.github.com/eslint/eslint/releases/tag/v9.19.0">2025-01-24</a></br><h2>Features</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/1637b8e87df5c7f58ab71e0e159f4b96c998e070"><code>1637b8e</code></a> feat: add <code>--report-unused-inline-configs</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2713510176" data-permission-text="Title is private" data-url="eslint/eslint#19201" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19201/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19201">#19201</a>) (Josh Goldberg ✨)</li> </ul> <h2>Bug Fixes</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/aae67172ab9631b4267fc03f64d3c3d6d1fcda73"><code>aae6717</code></a> fix: sync rule type header comments automatically (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2759484443" data-permission-text="Title is private" data-url="eslint/eslint#19276" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19276/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19276">#19276</a>) (Francesco Trotta)</li> </ul> <h2>Documentation</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/cfea9abe0e27cf2ce1d27232b8c70555397e141b"><code>cfea9ab</code></a> docs: Clarify overrideConfig option (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2810123187" data-permission-text="Title is private" data-url="eslint/eslint#19370" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19370/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19370">#19370</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/2b84f666cd7474bb061e2f12205af57f5dbb89d6"><code>2b84f66</code></a> docs: Update README (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2805168609" data-permission-text="Title is private" data-url="eslint/eslint#19362" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19362/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19362">#19362</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/044f93cbbe71a45130156004509083814e2b9669"><code>044f93c</code></a> docs: clarify frozen rule description (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2800331000" data-permission-text="Title is private" data-url="eslint/eslint#19351" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19351/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19351">#19351</a>) (Pavel)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/797ee7c0d669678b90c5d5742228bc7b24353f79"><code>797ee7c</code></a> docs: fix Bluesky links (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2809725778" data-permission-text="Title is private" data-url="eslint/eslint#19368" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19368/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19368">#19368</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/81a9c0ebc33dd33765711296f827c4448c80163d"><code>81a9c0e</code></a> docs: Update README (GitHub Actions Bot)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/093fb3d40286588c2c425b738426ebfe5d142a63"><code>093fb3d</code></a> docs: replace <code>var</code> with <code>let</code> and <code>const</code> in rule examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2807316643" data-permission-text="Title is private" data-url="eslint/eslint#19365" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19365/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19365">#19365</a>) (Tanuj Kanti)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/417de3298527e4f257e1ae7b02e1df9db3c9ed33"><code>417de32</code></a> docs: replace var with const in rule examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2801963621" data-permission-text="Title is private" data-url="eslint/eslint#19352" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19352/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19352">#19352</a>) (jj)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/17f2aaec16d5afbb0d219bce6ae01d7b15d74828"><code>17f2aae</code></a> docs: update getting-started config to match default generated config (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2767658177" data-permission-text="Title is private" data-url="eslint/eslint#19308" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19308/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19308">#19308</a>) (0xDev)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/8a0a5a8851f72982327c2aa3a41403963f025771"><code>8a0a5a8</code></a> docs: better <code>global ignores</code> instruction (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2764607108" data-permission-text="Title is private" data-url="eslint/eslint#19297" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19297/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19297">#19297</a>) (Jacopo Marrone)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/6671a2cd8ccc710fefbccad9a813c3bea5f76c68"><code>6671a2c</code></a> docs: Update README (GitHub Actions Bot)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/e39d3f22ff793db42e1f1fc3808cbb12fc513118"><code>e39d3f2</code></a> docs: fix divider for rule category (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2754091628" data-permission-text="Title is private" data-url="eslint/eslint#19264" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19264/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19264">#19264</a>) (Tanuj Kanti)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/e0cf53f80a4b127524e0badc8999d5d1a247143f"><code>e0cf53f</code></a> docs: fix search result box position for small screens (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2780440880" data-permission-text="Title is private" data-url="eslint/eslint#19328" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19328/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19328">#19328</a>) (Tanuj Kanti)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/f92a6803a10c66cf77408b2bf29c17bcd63b1049"><code>f92a680</code></a> docs: replace var with let or const in rule examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2781210802" data-permission-text="Title is private" data-url="eslint/eslint#19331" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19331/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19331">#19331</a>) (Ravi Teja Kolla)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/b04b84bc17d4aaaea1326cb08196593624db02a2"><code>b04b84b</code></a> docs: revert accidental changes in TS config files docs (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2781743342" data-permission-text="Title is private" data-url="eslint/eslint#19336" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19336/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19336">#19336</a>) (Francesco Trotta)</li> </ul> <h2>Chores</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/9b9cb0584867916d50aa2e9590b132e2ef8ca59c"><code>9b9cb05</code></a> chore: upgrade @ eslint/[email protected] (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2810175086" data-permission-text="Title is private" data-url="eslint/eslint#19371" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19371/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19371">#19371</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/58560e70bb4dcb305343fcd7c893ac56a404f674"><code>58560e7</code></a> chore: package.json update for @ eslint/js release (Jenkins)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/20897070913418078d8f1ea9a877d223650dff73"><code>2089707</code></a> test: fix failing test in Node.js v22.13.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2793909318" data-permission-text="Title is private" data-url="eslint/eslint#19345" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19345/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19345">#19345</a>) (Francesco Trotta)</li> </ul> </li> </ul> from <a href="https://redirect.github.com/eslint/eslint/releases">@eslint/js GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhNWJiYTlkNy1mYjExLTQwOTItYWM2OS1jYzZjZGY3MDM3YmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImE1YmJhOWQ3LWZiMTEtNDA5Mi1hYzY5LWNjNmNkZjcwMzdiYyJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/spine-semantic-infrastructure/project/b121e0a0-7979-4b24-be4d-3b874e16b0c8?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/spine-semantic-infrastructure/project/b121e0a0-7979-4b24-be4d-3b874e16b0c8/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/spine-semantic-infrastructure/project/b121e0a0-7979-4b24-be4d-3b874e16b0c8/settings/integration?pkg=@eslint/js&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@eslint/js","from":"9.19.0","to":"9.20.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"a5bba9d7-fb11-4092-ac69-cc6cdf7037bc","prPublicId":"a5bba9d7-fb11-4092-ac69-cc6cdf7037bc","packageManager":"npm","priorityScoreList":[],"projectPublicId":"b121e0a0-7979-4b24-be4d-3b874e16b0c8","projectUrl":"https://app.snyk.io/org/spine-semantic-infrastructure/project/b121e0a0-7979-4b24-be4d-3b874e16b0c8?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2025-02-07T21:08:27.344Z"},"vulns":[]}' Co-authored-by: snyk-bot <[email protected]>

![snyk-top-banner](https://redirect.github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123) <h3>Snyk has created this PR to upgrade eslint from 9.19.0 to 9.20.1.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **2 versions** ahead of your current version. - The recommended version was released **22 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>eslint</b></summary> <ul> <li> <b>9.20.1</b> - <a href="https://redirect.github.com/eslint/eslint/releases/tag/v9.20.1">2025-02-11</a></br><h2>Bug Fixes</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/274f054f19f5f490d9496c6eee4bcd8620d2f4be"><code>274f054</code></a> fix: fix <code>RuleContext</code> type (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2841823443" data-permission-text="Title is private" data-url="eslint/eslint#19417" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19417/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19417">#19417</a>) (Francesco Trotta)</li> </ul> <h2>Documentation</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/fe3ccb2ff43a9f20a7801c679f7d41f6a7ed3ddc"><code>fe3ccb2</code></a> docs: allow typing in search box while dropdown is open (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2845740480" data-permission-text="Title is private" data-url="eslint/eslint#19424" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19424/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19424">#19424</a>) (Amaresh S M)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/93c78a5c58edb7ead9bff87c874d2ff9b824ec04"><code>93c78a5</code></a> docs: Add instructions for pnpm compat (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2843677363" data-permission-text="Title is private" data-url="eslint/eslint#19422" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19422/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19422">#19422</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/b476a930bb3a6d644c482747d985f5da0d89e1e9"><code>b476a93</code></a> docs: Fix Keyboard Navigation for Search Results (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2840904681" data-permission-text="Title is private" data-url="eslint/eslint#19416" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19416/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19416">#19416</a>) (Amaresh S M)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/ccb60c0b1452e73750e3734c9cd7c7b12c473827"><code>ccb60c0</code></a> docs: Update README (GitHub Actions Bot)</li> </ul> </li> <li> <b>9.20.0</b> - <a href="https://redirect.github.com/eslint/eslint/releases/tag/v9.20.0">2025-02-07</a></br><h2>Features</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/e89a54a3090f3503daf5e36b02b0035c993e3fd1"><code>e89a54a</code></a> feat: change behavior of inactive flags (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2821852074" data-permission-text="Title is private" data-url="eslint/eslint#19386" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19386/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19386">#19386</a>) (Milos Djermanovic)</li> </ul> <h2>Bug Fixes</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/91d4d9f62095e302c71595cc04c47073f366315c"><code>91d4d9f</code></a> fix: Bring types in sync with @ eslint/core (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2683913007" data-permission-text="Title is private" data-url="eslint/eslint#19157" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19157/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19157">#19157</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/fa25c7a79edee280f275fbc35b83bcde906d1480"><code>fa25c7a</code></a> fix: Emit warning when empty config file is used (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2828450158" data-permission-text="Title is private" data-url="eslint/eslint#19399" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19399/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19399">#19399</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/31a9fd03d23aecf2b1e0c9b3df27554aff245723"><code>31a9fd0</code></a> fix: Clearer error message for wrong plugin format (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2818949219" data-permission-text="Title is private" data-url="eslint/eslint#19380" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19380/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19380">#19380</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/61d99e38f248f4d9abc09d970c4eebddd1af86ca"><code>61d99e3</code></a> fix: Better error message for unserializable parser (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2821677106" data-permission-text="Title is private" data-url="eslint/eslint#19384" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19384/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19384">#19384</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/db1b9a66e387e573f45885687dfefc04ab2877fe"><code>db1b9a6</code></a> fix: Ensure module scope is checked for references in <code>consistent-this</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2819044020" data-permission-text="Title is private" data-url="eslint/eslint#19383" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19383/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19383">#19383</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/8bcd820f37f2361e4f7261a9876f52d21bd9de8f"><code>8bcd820</code></a> fix: <code>arrow-body-style</code> crash with single-token body (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2815684602" data-permission-text="Title is private" data-url="eslint/eslint#19379" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19379/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19379">#19379</a>) (Milos Djermanovic)</li> </ul> <h2>Documentation</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/b7012c85f3c0f683baeffb6d856faf86c4d41702"><code>b7012c8</code></a> docs: rewrite examples with var using let and const (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2833783439" data-permission-text="Title is private" data-url="eslint/eslint#19407" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19407/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19407">#19407</a>) (Mueez Javaid Hashmi)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/64063765afa5bf29855d996ccabfaa93b19bd458"><code>6406376</code></a> docs: Update README (GitHub Actions Bot)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/350f2b9349bc8d2230cd953c14b77071f2961f47"><code>350f2b9</code></a> docs: rewrite some examples with var using let and const (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2831133301" data-permission-text="Title is private" data-url="eslint/eslint#19404" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19404/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19404">#19404</a>) (Mueez Javaid Hashmi)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/93c325a7a841d0fe4b5bf79efdec832e7c8f805f"><code>93c325a</code></a> docs: rewrite examples with var using let and const (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2827905788" data-permission-text="Title is private" data-url="eslint/eslint#19398" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19398/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19398">#19398</a>) (Mueez Javaid Hashmi)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/56ff4048e053374db39201e7e880bde4c930e19f"><code>56ff404</code></a> docs: replace var with let or const in rules docs (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2825955857" data-permission-text="Title is private" data-url="eslint/eslint#19396" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19396/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19396">#19396</a>) (Daniel Harbrueger)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/4053226996bbdec1ffdef8af1b9d7f5aa4b11b86"><code>4053226</code></a> docs: change <code>sourceType</code> in <code>no-eval</code> examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2825778899" data-permission-text="Title is private" data-url="eslint/eslint#19393" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19393/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19393">#19393</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/1324af027986d655848ee1a9dcb89a527917ea3e"><code>1324af0</code></a> docs: replace var with let and const in rules docs (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2825591567" data-permission-text="Title is private" data-url="eslint/eslint#19392" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19392/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19392">#19392</a>) (Daniel Harbrueger)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/8b87e007bb2ba59b73061d22ef34baffb5656b79"><code>8b87e00</code></a> docs: replace <code>var</code> with <code>const</code> and <code>let</code> in rules (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2823117975" data-permission-text="Title is private" data-url="eslint/eslint#19389" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19389/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19389">#19389</a>) (Tanuj Kanti)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/758c66bc8d83cd4eda9639b0745f0d0fb70f04f4"><code>758c66b</code></a> docs: Explain what frozen rules mean (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2819010049" data-permission-text="Title is private" data-url="eslint/eslint#19382" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19382/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19382">#19382</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/0ef8bb859c988e558683c2d8bd9c9606f22e456c"><code>0ef8bb8</code></a> docs: additional checks for rule examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2802981267" data-permission-text="Title is private" data-url="eslint/eslint#19358" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19358/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19358">#19358</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/58ab2f69d2d4cf9b49bf3fd303795040ec761ebd"><code>58ab2f6</code></a> docs: fix order of installation steps in getting started (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2777974394" data-permission-text="Title is private" data-url="eslint/eslint#19326" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19326/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19326">#19326</a>) (Tanuj Kanti)</li> </ul> <h2>Chores</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/979097a3b4c656e2d9faabd4a52010d6647911f6"><code>979097a</code></a> chore: upgrade @ eslint/[email protected] (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2839104411" data-permission-text="Title is private" data-url="eslint/eslint#19412" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19412/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19412">#19412</a>) (Francesco Trotta)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/031734efcb27e0d800da7ec32f5d5dae55f80564"><code>031734e</code></a> chore: package.json update for @ eslint/js release (Jenkins)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/d4c47c3738f2bf53b4f6a1cf505861b35875ac5f"><code>d4c47c3</code></a> test: avoid empty config warning in test output (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2834930216" data-permission-text="Title is private" data-url="eslint/eslint#19408" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19408/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19408">#19408</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/67dd82ab88d784b6f36e471b6a5c6f64e37f9485"><code>67dd82a</code></a> chore: update dependency @ eslint/json to ^0.10.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2822208573" data-permission-text="Title is private" data-url="eslint/eslint#19387" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19387/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19387">#19387</a>) (renovate[bot])</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/15ac0e182486f32d63171a310050383e15767697"><code>15ac0e1</code></a> chore: add permissions: read-all to stale.yml workflow (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2812916549" data-permission-text="Title is private" data-url="eslint/eslint#19374" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19374/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19374">#19374</a>) (Josh Goldberg ✨)</li> </ul> </li> <li> <b>9.19.0</b> - <a href="https://redirect.github.com/eslint/eslint/releases/tag/v9.19.0">2025-01-24</a></br><h2>Features</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/1637b8e87df5c7f58ab71e0e159f4b96c998e070"><code>1637b8e</code></a> feat: add <code>--report-unused-inline-configs</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2713510176" data-permission-text="Title is private" data-url="eslint/eslint#19201" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19201/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19201">#19201</a>) (Josh Goldberg ✨)</li> </ul> <h2>Bug Fixes</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/aae67172ab9631b4267fc03f64d3c3d6d1fcda73"><code>aae6717</code></a> fix: sync rule type header comments automatically (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2759484443" data-permission-text="Title is private" data-url="eslint/eslint#19276" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19276/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19276">#19276</a>) (Francesco Trotta)</li> </ul> <h2>Documentation</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/cfea9abe0e27cf2ce1d27232b8c70555397e141b"><code>cfea9ab</code></a> docs: Clarify overrideConfig option (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2810123187" data-permission-text="Title is private" data-url="eslint/eslint#19370" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19370/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19370">#19370</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/2b84f666cd7474bb061e2f12205af57f5dbb89d6"><code>2b84f66</code></a> docs: Update README (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2805168609" data-permission-text="Title is private" data-url="eslint/eslint#19362" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19362/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19362">#19362</a>) (Nicholas C. Zakas)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/044f93cbbe71a45130156004509083814e2b9669"><code>044f93c</code></a> docs: clarify frozen rule description (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2800331000" data-permission-text="Title is private" data-url="eslint/eslint#19351" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19351/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19351">#19351</a>) (Pavel)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/797ee7c0d669678b90c5d5742228bc7b24353f79"><code>797ee7c</code></a> docs: fix Bluesky links (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2809725778" data-permission-text="Title is private" data-url="eslint/eslint#19368" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19368/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19368">#19368</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/81a9c0ebc33dd33765711296f827c4448c80163d"><code>81a9c0e</code></a> docs: Update README (GitHub Actions Bot)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/093fb3d40286588c2c425b738426ebfe5d142a63"><code>093fb3d</code></a> docs: replace <code>var</code> with <code>let</code> and <code>const</code> in rule examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2807316643" data-permission-text="Title is private" data-url="eslint/eslint#19365" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19365/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19365">#19365</a>) (Tanuj Kanti)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/417de3298527e4f257e1ae7b02e1df9db3c9ed33"><code>417de32</code></a> docs: replace var with const in rule examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2801963621" data-permission-text="Title is private" data-url="eslint/eslint#19352" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19352/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19352">#19352</a>) (jj)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/17f2aaec16d5afbb0d219bce6ae01d7b15d74828"><code>17f2aae</code></a> docs: update getting-started config to match default generated config (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2767658177" data-permission-text="Title is private" data-url="eslint/eslint#19308" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19308/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19308">#19308</a>) (0xDev)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/8a0a5a8851f72982327c2aa3a41403963f025771"><code>8a0a5a8</code></a> docs: better <code>global ignores</code> instruction (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2764607108" data-permission-text="Title is private" data-url="eslint/eslint#19297" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19297/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19297">#19297</a>) (Jacopo Marrone)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/6671a2cd8ccc710fefbccad9a813c3bea5f76c68"><code>6671a2c</code></a> docs: Update README (GitHub Actions Bot)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/e39d3f22ff793db42e1f1fc3808cbb12fc513118"><code>e39d3f2</code></a> docs: fix divider for rule category (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2754091628" data-permission-text="Title is private" data-url="eslint/eslint#19264" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19264/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19264">#19264</a>) (Tanuj Kanti)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/e0cf53f80a4b127524e0badc8999d5d1a247143f"><code>e0cf53f</code></a> docs: fix search result box position for small screens (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2780440880" data-permission-text="Title is private" data-url="eslint/eslint#19328" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19328/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19328">#19328</a>) (Tanuj Kanti)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/f92a6803a10c66cf77408b2bf29c17bcd63b1049"><code>f92a680</code></a> docs: replace var with let or const in rule examples (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2781210802" data-permission-text="Title is private" data-url="eslint/eslint#19331" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19331/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19331">#19331</a>) (Ravi Teja Kolla)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/b04b84bc17d4aaaea1326cb08196593624db02a2"><code>b04b84b</code></a> docs: revert accidental changes in TS config files docs (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2781743342" data-permission-text="Title is private" data-url="eslint/eslint#19336" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19336/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19336">#19336</a>) (Francesco Trotta)</li> </ul> <h2>Chores</h2> <ul> <li><a href="https://redirect.github.com/eslint/eslint/commit/9b9cb0584867916d50aa2e9590b132e2ef8ca59c"><code>9b9cb05</code></a> chore: upgrade @ eslint/[email protected] (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2810175086" data-permission-text="Title is private" data-url="eslint/eslint#19371" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19371/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19371">#19371</a>) (Milos Djermanovic)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/58560e70bb4dcb305343fcd7c893ac56a404f674"><code>58560e7</code></a> chore: package.json update for @ eslint/js release (Jenkins)</li> <li><a href="https://redirect.github.com/eslint/eslint/commit/20897070913418078d8f1ea9a877d223650dff73"><code>2089707</code></a> test: fix failing test in Node.js v22.13.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2793909318" data-permission-text="Title is private" data-url="eslint/eslint#19345" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/19345/hovercard" href="https://redirect.github.com/eslint/eslint/pull/19345">#19345</a>) (Francesco Trotta)</li> </ul> </li> </ul> from <a href="https://redirect.github.com/eslint/eslint/releases">eslint GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTI3ZTQ4YS00NjAzLTRlMDYtOTRiZC0yYjcyOTZjMmQxMjgiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxMjdlNDhhLTQ2MDMtNGUwNi05NGJkLTJiNzI5NmMyZDEyOCJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/spine-semantic-infrastructure/project/b121e0a0-7979-4b24-be4d-3b874e16b0c8?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/spine-semantic-infrastructure/project/b121e0a0-7979-4b24-be4d-3b874e16b0c8/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/spine-semantic-infrastructure/project/b121e0a0-7979-4b24-be4d-3b874e16b0c8/settings/integration?pkg=eslint&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"eslint","from":"9.19.0","to":"9.20.1"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"3127e48a-4603-4e06-94bd-2b7296c2d128","prPublicId":"3127e48a-4603-4e06-94bd-2b7296c2d128","packageManager":"npm","priorityScoreList":[],"projectPublicId":"b121e0a0-7979-4b24-be4d-3b874e16b0c8","projectUrl":"https://app.snyk.io/org/spine-semantic-infrastructure/project/b121e0a0-7979-4b24-be4d-3b874e16b0c8?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":2,"publishedDate":"2025-02-11T17:15:30.863Z"},"vulns":[]}' Co-authored-by: snyk-bot <[email protected]>

docs: additional checks for rule examples

7f671c6

mdjermanovic requested a review from a team as a code owner January 21, 2025 22:53

eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jan 21, 2025

mdjermanovic commented Jan 21, 2025

View reviewed changes

fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jan 24, 2025

fasttime reviewed Jan 24, 2025

View reviewed changes

fasttime added the build This change relates to ESLint's build process label Jan 24, 2025

fasttime reviewed Jan 25, 2025

View reviewed changes

fasttime approved these changes Jan 28, 2025

View reviewed changes

fasttime merged commit 0ef8bb8 into main Jan 28, 2025
30 checks passed

fasttime deleted the docs-check-rule-errors branch January 28, 2025 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

docs: additional checks for rule examples #19358

docs: additional checks for rule examples #19358

Uh oh!

mdjermanovic commented Jan 21, 2025

Uh oh!

netlify bot commented Jan 21, 2025 •

edited

Loading

Uh oh!

mdjermanovic Jan 21, 2025

Uh oh!

mdjermanovic Jan 21, 2025

Uh oh!

mdjermanovic Jan 21, 2025

Uh oh!

fasttime Jan 24, 2025 •

edited

Loading

Uh oh!

mdjermanovic Jan 24, 2025

Uh oh!

fasttime Jan 25, 2025

Uh oh!

mdjermanovic Jan 27, 2025

Uh oh!

fasttime left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	"\x1B[0m \x1B[2m51:1\x1B[22m \x1B[31merror\x1B[39m Duplicate /* eslint no-restricted-syntax */ configuration comment. Each example should contain only one. Split this example into multiple examples\x1B[0m\n" +
	"\x1B[0m \x1B[2m51:1\x1B[22m \x1B[31merror\x1B[39m Duplicate /* eslint no-restricted-syntax */ configuration comment. Each example should contain only one. Split this example into multiple examples\x1B[0m\n" +

Uh oh!

docs: additional checks for rule examples #19358

docs: additional checks for rule examples #19358

Uh oh!

Conversation

mdjermanovic commented Jan 21, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint ready!

Uh oh!

mdjermanovic Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

mdjermanovic Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

mdjermanovic Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

fasttime Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdjermanovic Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

fasttime Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

mdjermanovic Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

fasttime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jan 21, 2025 •

edited

Loading

fasttime Jan 24, 2025 •

edited

Loading