Skip to content

docs: fix divider for rule category #19264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nzakas merged 4 commits into from
Jan 13, 2025
Merged

docs: fix divider for rule category #19264

nzakas merged 4 commits into from
Jan 13, 2025

Conversation

@Tanujkanti4441
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 commented Dec 21, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The divider of newly added category is inconsistent in different screen size.
Screenshot 2024-12-21 195919

Screenshot 2024-12-21 200006

updated the rule.scss code to fix this.

Is there anything you'd like reviewers to focus on?

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner December 21, 2024 14:32
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 21, 2024
@netlify
Copy link

netlify bot commented Dec 21, 2024 •
edited
Loading

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit e950ac3
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6776caddca061e0009b18bff
😎 Deploy Preview https://deploy-preview-19264--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 21, 2024
amareshsm
amareshsm previously approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@amareshsm amareshsm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! I'd like to have another review of this.

@nzakas
Copy link
Member

nzakas commented Dec 30, 2024

It looks like the spacing is a bit off under the snowflake. The text is too far down.

Screenshot 2024-12-30 at 17-21-24 Rules Reference - ESLint - Pluggable JavaScript Linter

@Tanujkanti4441
Copy link
Contributor Author

Tanujkanti4441 commented Dec 31, 2024

It looks like the spacing is a bit off under the snowflake. The text is too far down.

Fixed!