Skip to content

Conversation

lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Nov 28, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Hello,

I've added a missing backtick for the inline code block in no-async-promise-executor.md.

It was included in the paragraph above but was missing in the one below. (Please refer to the screenshot below.)

image

Is there anything you'd like reviewers to focus on?

Nope!

@lumirlumir lumirlumir requested a review from a team as a code owner November 28, 2024 09:17
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Nov 28, 2024
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 88609cb
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6748355de6f22100082e8aae
😎 Deploy Preview https://deploy-preview-19188--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic changed the title docs: add missing backtick to no-async-promise-executor.md docs: add missing backtick to no-async-promise-executor Nov 28, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 0c19417 into eslint:main Nov 28, 2024
27 checks passed
@lumirlumir lumirlumir deleted the docs-no-async-promise-executor branch November 28, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants