docs: use higher contrast color tokens for code comments #19187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Ooh, interesting. That looks to me like a more root issue about text using light mode styles in dark mode when no-js is enabled. I think that's out of scope of this PR? |
|
Oh! I was wrong, code comments just aren't using the same dark/light mode queries as most of the app. Updated. |
07eac8a to
b2fc957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes eslint/eslint.org#665. Corresponds to eslint/eslint.org#666.
What changes did you make? (Give an overview)
I swapped out the hardcoded comment colors with the closest theme tokens that had sufficient contrast.
Is there anything you'd like reviewers to focus on?
If there are other ad-hoc colors just barely off from color tokens, I'd be happy to clean those up in a followup?