fix: enable retry concurrency limit for readFile() #19077
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
1 task
nzakas
commented
Oct 31, 2024
lib/eslint/eslint.js
Outdated
| const controller = new AbortController(); | ||
| const retryCodes = new Set(["ENFILE", "EMFILE"]); | ||
| const retrier = new Retrier(error => retryCodes.has(error.code)); | ||
| const retrier = new Retrier(error => retryCodes.has(error.code), { signal: controller.signal, concurrency: 100 }); |
There was a problem hiding this comment.
I set concurrency to 100 to match @fasttime's prototype. I tried with values from 100-1000 and found performance was basically the same. We can always tweak this later if we the need.
mdjermanovic
reviewed
Nov 1, 2024
mdjermanovic
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
LGTM, thanks!
If possible, would like @fasttime to verify before today's release.
Thompson1985
approved these changes
Nov 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated
@humanwhocodes/retryand set concurrency to 100.fixes #18977
Is there anything you'd like reviewers to focus on?
I didn't add any new tests for this because I couldn't come up with one that failed without it. Functionally, this should result in no difference to the end user and assuming our existing tests pass, I think we're okay.