Skip to content

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 29, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refs #19073. Adds several no-invalid-regexp tests with RegExp Modifiers.

What changes did you make? (Give an overview)

Added tests.

Is there anything you'd like reviewers to focus on?

The @eslint-community/regexpp dependency has already been updated in #19065.

@mdjermanovic mdjermanovic requested a review from a team as a code owner October 29, 2024 06:49
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Oct 29, 2024
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion new syntax This issue is related to new syntax that has reached stage 4 and removed chore This change is not user-facing labels Oct 29, 2024
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 15fdc9b
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6720857293667100088e3c76

@mdjermanovic mdjermanovic added the chore This change is not user-facing label Oct 29, 2024
@mdjermanovic mdjermanovic mentioned this pull request Oct 29, 2024
13 tasks
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@snitin315 snitin315 merged commit f48a2a0 into main Oct 29, 2024
26 checks passed
@snitin315 snitin315 deleted the noinvalidregexp-modifiers branch October 29, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing new syntax This issue is related to new syntax that has reached stage 4

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants