Skip to content

Conversation

karlhorky
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Followup to DefinitelyTyped/DefinitelyTyped#70735 and #18928, where @types/eslint was removed from DefinitelyTyped

Is there anything you'd like reviewers to focus on?

Happy to reword (eg. to mentioning the ESLint project or the eslint/eslint repo), in case referring to the directory is the wrong way to explain this.

@karlhorky karlhorky requested a review from a team as a code owner October 23, 2024 16:20
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 6bbf2f2
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/671a0c5c75ba21000714b0fd
😎 Deploy Preview https://deploy-preview-19049--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 24, 2024
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @karlhorky, I only have one suggestion.

@karlhorky
Copy link
Contributor Author

karlhorky commented Oct 24, 2024

I guess the failing test run is unrelated?

npm run test:emfile
  npm run test:emfile
  shell: /bin/bash -e {0}

> [email protected] test:emfile
> node tools/check-emfile-handling.js

Detected Linux file limit of 1048576.
Generating 100000 files in tmp/emfile-check...
Running ESLint...
(node:3071) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
(Use `node --trace-warnings ...` to show where the warning was created)

Oops! Something went wrong! :(

ESLint: 9.13.0

Error: EMFILE: too many open files, open '/Users/runner/work/eslint/eslint/tmp/emfile-check/file_195.js'
    at async open (node:internal/fs/promises:639:[2](https://github.com/eslint/eslint/actions/runs/11496004290/job/31996756139#step:7:2)5)
    at async Object.readFile (node:internal/fs/promises:1242:14)
    at async Promise.all (index 10557)
    at async ESLint.lintFiles (/Users/runner/work/eslint/eslint/lib/eslint/eslint.js:759:25)
    at async Object.execute (/Users/runner/work/eslint/eslint/lib/cli.js:498:2[3](https://github.com/eslint/eslint/actions/runs/11496004290/job/31996756139#step:7:3))
    at async main (/Users/runner/work/eslint/eslint/bin/eslint.js:158:22)
node:child_process:966
    throw err;
    ^

Error: Command failed: node bin/eslint.js tmp/emfile-check -c tests/fixtures/emfile/eslint.config.js
    at genericNodeError (node:internal/errors:98[4](https://github.com/eslint/eslint/actions/runs/11496004290/job/31996756139#step:7:5):1[5](https://github.com/eslint/eslint/actions/runs/11496004290/job/31996756139#step:7:6))
    at wrappedFn (node:internal/errors:538:14)
    at checkExecSyncError (node:child_process:891:11)
    at execSync (node:child_process:9[6](https://github.com/eslint/eslint/actions/runs/11496004290/job/31996756139#step:7:7)3:15)
    at Object.<anonymous> (/Users/runner/work/eslint/eslint/tools/check-emfile-handling.js:98:1)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:1[7](https://github.com/eslint/eslint/actions/runs/11496004290/job/31996756139#step:7:8)4:12) {
  status: 2,
  signal: null,
  output: [ null, null, null ],
  pid: 3071,
  stdout: null,
  stderr: null
}

Node.js v20.1[8](https://github.com/eslint/eslint/actions/runs/11496004290/job/31996756139#step:7:9).0
Error: Process completed with exit code 1.

@fasttime
Copy link
Member

I guess the failing test run is unrelated?

It's related to #18568, if you happen to know how to fix it.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit ee0a77e into eslint:main Oct 24, 2024
26 checks passed
@karlhorky karlhorky deleted the patch-1 branch October 24, 2024 10:54
@karlhorky
Copy link
Contributor Author

Thanks for the review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants