-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
docs: change link from @types/eslint to lib/types #19049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @karlhorky, I only have one suggestion.
Co-authored-by: Francesco Trotta <[email protected]>
I guess the failing test run is unrelated?
|
It's related to #18568, if you happen to know how to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for the review and merge! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Followup to DefinitelyTyped/DefinitelyTyped#70735 and #18928, where
@types/eslint
was removed from DefinitelyTypedIs there anything you'd like reviewers to focus on?
Happy to reword (eg. to mentioning the ESLint project or the
eslint/eslint
repo), in case referring to the directory is the wrong way to explain this.