Skip to content

fix: Issues with type definitions #18940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2024
Merged

fix: Issues with type definitions #18940

merged 4 commits into from
Sep 27, 2024

Conversation

aryaemami59
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR:

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Sep 21, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 21, 2024 •
edited
Loading

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit b4193f2
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/66f59c0d50568700089980b9
😎 Deploy Preview https://deploy-preview-18940--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aryaemami59 aryaemami59 mentioned this pull request Sep 23, 2024
Closed
1 task
@aryaemami59 aryaemami59 force-pushed the fix-type-defs branch 2 times, most recently from b786fdb to 2adce33 Compare September 24, 2024 15:48
@aryaemami59 aryaemami59 marked this pull request as ready for review September 24, 2024 16:00
@aryaemami59 aryaemami59 requested a review from a team as a code owner September 24, 2024 16:00
@aryaemami59
Copy link
Contributor Author

Not sure why but it looks like the last step in the eslint-visitor-keys job is running TypeScript v4.5.5 and since ES2022 was not yet available in v4.5.5 we end up with the CI job failing.

@fasttime
Copy link
Member

Not sure why but it looks like the last step in the eslint-visitor-keys job is running TypeScript v4.5.5 and since ES2022 was not yet available in v4.5.5 we end up with the CI job failing.

This is being tracked in eslint/js#630.

fasttime
fasttime reviewed Sep 25, 2024
View reviewed changes
@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 25, 2024
@nzakas
Copy link
Member

nzakas commented Sep 25, 2024

Can we also add add @arethetypeswrong/cli to the CI to verify these changes?

@aryaemami59
Copy link
Contributor Author

@nzakas That's an excellent idea I'll add it.

@aryaemami59 aryaemami59 force-pushed the fix-type-defs branch 2 times, most recently from 30161c3 to 205e2fb Compare September 25, 2024 18:27
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

JoshuaKGoldberg
JoshuaKGoldberg reviewed Sep 25, 2024
View reviewed changes
fasttime
fasttime reviewed Sep 26, 2024
View reviewed changes
@aryaemami59 aryaemami59 force-pushed the fix-type-defs branch 3 times, most recently from 136a6ca to 1d67ba5 Compare September 26, 2024 10:34
fasttime
fasttime reviewed Sep 26, 2024
View reviewed changes
@aryaemami59 aryaemami59 force-pushed the fix-type-defs branch 4 times, most recently from 9ad6db6 to 72b50af Compare September 26, 2024 16:07
nzakas
nzakas approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @fasttime to verify before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzakas nzakas nzakas approved these changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@snitin315 snitin315 snitin315 left review comments

@fasttime fasttime fasttime approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly github actions

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Fix type loading errors

5 participants

@aryaemami59 @fasttime @nzakas @JoshuaKGoldberg @snitin315